Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 572933006: nanobench: lazily decode bitmaps from SKPs (Closed)

Created:
6 years, 3 months ago by mtklein_C
Modified:
6 years, 3 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

nanobench: lazily decode bitmaps from SKPs This makes it considerably cheaper to run SKP recording benchmarks, without affecting their measurements and without really affecting SKP playback benchmarks at all. On my machine, running out/Release/nanobench --match skp --config nondrendering drops in run time from 6.7s to 2.5s, and the peak RAM usage drops from 129M to 50M. I'm strongly considering making this lazy decoding the default. BUG=skia:2944 Committed: https://skia.googlesource.com/skia/+/d664c21a38de98d8db210c46f7a8c4187f1534da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M bench/nanobench.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M gyp/bench.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M gyp/iOSShell.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
mtklein
6 years, 3 months ago (2014-09-16 20:17:34 UTC) #2
robertphillips
lgtm
6 years, 3 months ago (2014-09-16 20:21:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/572933006/1
6 years, 3 months ago (2014-09-16 20:29:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as d664c21a38de98d8db210c46f7a8c4187f1534da
6 years, 3 months ago (2014-09-16 20:36:18 UTC) #6
jcgregorio
On 2014/09/16 20:36:18, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) as ...
6 years, 3 months ago (2014-09-17 13:09:02 UTC) #7
jcgregorio
On 2014/09/17 13:09:02, jcgregorio wrote: > On 2014/09/16 20:36:18, I haz the power (commit-bot) wrote: ...
6 years, 3 months ago (2014-09-17 13:13:27 UTC) #8
mtklein
6 years, 3 months ago (2014-09-17 13:58:24 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/554583004/ by mtklein@google.com.

The reason for reverting is: skia:2944.

Powered by Google App Engine
This is Rietveld 408576698