Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 572933004: when we disable lcd for impl reasons, add kGenA8 to document the original intent (Closed)

Created:
6 years, 3 months ago by reed1
Modified:
6 years, 3 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

when we disable lcd for impl reasons, add kGenA8 to document the original intent BUG=skia: Committed: https://skia.googlesource.com/skia/+/3375c8047e7f10e6bf9a2ce1c2e8b0df08c56024

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M include/core/SkDevice.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
reed1
6 years, 3 months ago (2014-09-16 18:46:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/572933004/1
6 years, 3 months ago (2014-09-16 18:46:48 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-09-16 18:46:49 UTC) #5
bungeman-skia
lgtm
6 years, 3 months ago (2014-09-16 19:26:59 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 19:28:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 3375c8047e7f10e6bf9a2ce1c2e8b0df08c56024

Powered by Google App Engine
This is Rietveld 408576698