tools/gn/ninja_binary_target_writer.cc - Issue 572893002: GN: Refine 'complete' static library handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_binary_target_writer.cc

Issue 572893002: GN: Refine 'complete' static library handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/ninja_binary_target_writer.cc

diff --git a/tools/gn/ninja_binary_target_writer.cc b/tools/gn/ninja_binary_target_writer.cc

index b99de02282339481c3819f2a7631b907bb5a9c78..490fc9fead05a0df73628c9ba5d08ab7252ea813 100644

--- a/tools/gn/ninja_binary_target_writer.cc

+++ b/tools/gn/ninja_binary_target_writer.cc

@@ -423,6 +423,8 @@ void NinjaBinaryTargetWriter::ClassifyDependency(

}

+ } else if (target_->complete_static_lib() && dep->IsFinal()) {

+ non_linkable_deps->push_back(dep);

} else if (can_link_libs && dep->IsLinkable()) {

linkable_deps->push_back(dep);

} else {

« no previous file with comments | « no previous file | tools/gn/target.cc » ('j') | tools/gn/target.cc » ('J')