Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 572873005: cc: Stop passing the unused opaque rect out-param to blink. (Closed)

Created:
6 years, 3 months ago by danakj
Modified:
6 years, 3 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org, jamesr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Stop passing the unused opaque rect out-param to blink. Blink now has methods that don't take the rect out-param so use those. Then we can delete the old methods with the out-param in blink. R=vmpstr BUG=413479 Committed: https://crrev.com/9235f2eaee3783a9c64b6745131f970887ef351d Cr-Commit-Position: refs/heads/master@{#295092}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M cc/blink/web_content_layer_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
danakj
6 years, 3 months ago (2014-09-16 14:31:51 UTC) #1
vmpstr
lgtm
6 years, 3 months ago (2014-09-16 16:45:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/572873005/1
6 years, 3 months ago (2014-09-16 16:47:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 65ec2420d46644a9dd2b866f188d9716b2b51d50
6 years, 3 months ago (2014-09-16 17:22:11 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 17:23:47 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9235f2eaee3783a9c64b6745131f970887ef351d
Cr-Commit-Position: refs/heads/master@{#295092}

Powered by Google App Engine
This is Rietveld 408576698