Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 572873004: Revert r23962 "Configure d8 & cctest to suppress Windows error dialogs." (Closed)

Created:
6 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 3 months ago
Reviewers:
sigurds
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Revert r23962 "Configure d8 & cctest to suppress Windows error dialogs." Breaks compilation on Windows TBR=sigurds@chromium.org BUG=none LOG=n Committed: https://code.google.com/p/v8/source/detail?r=23963

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -33 lines) Patch
M src/d8.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M test/cctest/cctest.cc View 2 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jochen (gone - plz use gerrit)
6 years, 3 months ago (2014-09-16 09:14:00 UTC) #1
jochen (gone - plz use gerrit)
6 years, 3 months ago (2014-09-16 09:14:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23963 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698