Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 572853007: reland ce80b519af00bb6259e8c63f91fee5263d818124 with fix for failed test. (Closed)

Created:
6 years, 3 months ago by Evan Stade
Modified:
6 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, nona+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

reland ce80b519af00bb6259e8c63f91fee5263d818124 with fix for failed test. Fix some more for= usage. Also fix some controlled settings indicators. BUG=409938 R=dbeam@chromium.org Committed: https://crrev.com/8b2bcd7696a1edcc67caa79f89c8069766f2c4e7 Cr-Commit-Position: refs/heads/master@{#295201}

Patch Set 1 #

Patch Set 2 : with fix for bad merge (cf. patchset 1 for original CL) #

Patch Set 3 : merge conflict again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+354 lines, -271 lines) Patch
M chrome/browser/resources/options/browser_options.html View 1 2 25 chunks +141 lines, -99 lines 0 comments Download
M chrome/browser/resources/options/content_settings.html View 10 chunks +125 lines, -78 lines 0 comments Download
M chrome/browser/resources/options/controlled_setting.css View 2 chunks +1 line, -13 lines 0 comments Download
M chrome/browser/resources/options/home_page_overlay.html View 1 chunk +19 lines, -23 lines 0 comments Download
M chrome/browser/resources/options/hotword_confirm_overlay.html View 1 chunk +4 lines, -8 lines 0 comments Download
M chrome/browser/resources/options/import_data_overlay.html View 2 chunks +25 lines, -15 lines 0 comments Download
M chrome/browser/resources/options/language_add_language_overlay.html View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/manage_profile_overlay.html View 3 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/resources/options/reset_profile_settings_overlay.css View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/resources/options/reset_profile_settings_overlay.html View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/options/reset_profile_settings_overlay.js View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/startup_section.html View 1 chunk +15 lines, -9 lines 0 comments Download
M chrome/browser/resources/options/sync_section.html View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Evan Stade
6 years, 3 months ago (2014-09-16 21:27:59 UTC) #1
Dan Beam
lgtm
6 years, 3 months ago (2014-09-16 21:39:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/572853007/20001
6 years, 3 months ago (2014-09-16 22:02:34 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/4938) android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/4799) chromium_presubmit ...
6 years, 3 months ago (2014-09-16 22:08:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/572853007/40001
6 years, 3 months ago (2014-09-16 23:16:57 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001) as f92788ed49642d596e4f892f18a9fdd2a5029fea
6 years, 3 months ago (2014-09-17 01:03:04 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 01:04:04 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8b2bcd7696a1edcc67caa79f89c8069766f2c4e7
Cr-Commit-Position: refs/heads/master@{#295201}

Powered by Google App Engine
This is Rietveld 408576698