core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp - Issue 572853006: When forcing clear page data, no need to release colorspace when releasing pattern

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp

Issue 572853006: When forcing clear page data, no need to release colorspace when releasing pattern (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp

diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp

index 131edbe9b59febd639195bec1ed83c0bca7adb8a..77db4534fbd27f345ede1a73f9cb5ce3bbaea08e 100644

--- a/core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp

+++ b/core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp

@@ -229,6 +229,7 @@ void CPDF_DocPageData::Clear(FX_BOOL bForceRelease)

m_PatternMap.GetNextAssoc(pos, ptObj, ptData);

nCount = ptData->m_nCount;

if (bForceRelease || nCount < 2) {

+ ptData->m_Obj->SetForceClear(bForceRelease);

delete ptData->m_Obj;

ptData->m_Obj = NULL;

}

« no previous file with comments | « core/include/fpdfapi/fpdf_resource.h ('k') | core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp » ('j') | no next file with comments »