core/include/fpdfapi/fpdf_resource.h - Issue 572853006: When forcing clear page data, no need to release colorspace when releasing pattern

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/include/fpdfapi/fpdf_resource.h

Issue 572853006: When forcing clear page data, no need to release colorspace when releasing pattern (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/include/fpdfapi/fpdf_resource.h

diff --git a/core/include/fpdfapi/fpdf_resource.h b/core/include/fpdfapi/fpdf_resource.h

index a7a644435e0f94d7ae6076b71f4225cd86bc8f87..60346f124ca15120cf1eb9d3a78ebb09d44d2b48 100644

--- a/core/include/fpdfapi/fpdf_resource.h

+++ b/core/include/fpdfapi/fpdf_resource.h

@@ -739,9 +739,9 @@ public:

CFX_AffineMatrix m_ParentMatrix;

CPDF_Document* m_pDocument;

+ void SetForceClear(FX_BOOL bForceClear) { m_bForceClear = bForceClear; }

Tom Sepez 2014/09/16 19:18:06 nit: prefer functions to come before members (i.e.

protected:

+ FX_BOOL m_bForceClear;

CPDF_Pattern(const CFX_AffineMatrix* pParentMatrix);

Tom Sepez 2014/09/16 19:18:06 nit: Similarly, swap these two lines.

};

« no previous file with comments | « no previous file | core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp » ('j') | core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp » ('J')