Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 572853006: When forcing clear page data, no need to release colorspace when releasing pattern (Closed)

Created:
6 years, 3 months ago by Bo Xu
Modified:
5 years, 9 months ago
Reviewers:
Tom Sepez, jun_fang
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

When forcing clear page data, no need to release colorspace when releasing pattern BUG=414661 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/69dcf148b3755c11d5da47fbee767aa920ee2f58

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M core/include/fpdfapi/fpdf_resource.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Bo Xu
Hi Tom, please review this one.
6 years, 3 months ago (2014-09-16 18:56:12 UTC) #2
Tom Sepez
LGTM. Just some minor style nits. https://codereview.chromium.org/572853006/diff/1/core/include/fpdfapi/fpdf_resource.h File core/include/fpdfapi/fpdf_resource.h (right): https://codereview.chromium.org/572853006/diff/1/core/include/fpdfapi/fpdf_resource.h#newcode742 core/include/fpdfapi/fpdf_resource.h:742: void SetForceClear(FX_BOOL bForceClear) ...
6 years, 3 months ago (2014-09-16 19:18:07 UTC) #3
jun_fang
https://codereview.chromium.org/572853006/diff/1/core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp File core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp (right): https://codereview.chromium.org/572853006/diff/1/core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp#newcode232 core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp:232: ptData->m_Obj->SetForceClear(bForceRelease); Check whether ptData->m_Obj is not NULL? https://codereview.chromium.org/572853006/diff/1/core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp File ...
6 years, 3 months ago (2014-09-16 19:24:38 UTC) #4
Bo Xu
6 years, 3 months ago (2014-09-16 20:24:43 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 69dcf14 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698