Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 572823002: fix for high resolution timer on windows. (Closed)

Created:
6 years, 3 months ago by cpu_(ooo_6.6-7.5)
Modified:
6 years, 3 months ago
Reviewers:
CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@2125
Project:
chromium
Visibility:
Public.

Description

fix for high resolution timer on windows. (merge to branch) The CLs here https://codereview.chromium.org/489793003 and here https://codereview.chromium.org/395913006 In isolation look correct but taken together cause a overflow or underflow bug. Basically the message loop was calling Time::ActivateHighResolutionTimer(false) all the time (or very often) so the g_high_res_timer_count was underflowing or overflowing. Now messageloop only calls ActivateHighResolutionTimer in a balanced way. This can make the base_unittests fail as well with --gtest_filter=MessageLoopTest.HighResolutionTimer BUG=153139 TEST=included, see bug for manual testing. Review URL: https://codereview.chromium.org/541203002 Cr-Commit-Position: refs/heads/master@{#293434} (cherry picked from commit 3365a510b17169457292bdb6144cc8b95fb7ea34) Committed: https://chromium.googlesource.com/chromium/src/+/2a6f786b6a8a9f9f09ce0dd632e749e4f7ca1efd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M base/message_loop/message_loop.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M base/message_loop/message_loop_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M base/time/time_win.cc View 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
cpu_(ooo_6.6-7.5)
6 years, 3 months ago (2014-09-16 02:08:17 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 2a6f786.

Powered by Google App Engine
This is Rietveld 408576698