Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Unified Diff: chrome/common/extensions/manifest_unittest.cc

Issue 572813002: Refactor ExtensionManifestTest to allow usage in src/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_unittest.cc
diff --git a/chrome/common/extensions/manifest_unittest.cc b/chrome/common/extensions/manifest_unittest.cc
index 97150f19fdc13c32972f3c036172a220d132ca76..6bf35e6b9079beeb07e6b966481ca0919c66e75b 100644
--- a/chrome/common/extensions/manifest_unittest.cc
+++ b/chrome/common/extensions/manifest_unittest.cc
@@ -23,9 +23,10 @@ namespace extensions {
namespace errors = manifest_errors;
namespace keys = manifest_keys;
-class ManifestTest : public testing::Test {
+// Not named "ManifestTest" because a test utility class has that name.
+class ManifestUnitTest : public testing::Test {
public:
- ManifestTest() : default_value_("test") {}
+ ManifestUnitTest() : default_value_("test") {}
protected:
void AssertType(Manifest* manifest, Manifest::Type type) {
@@ -59,7 +60,7 @@ class ManifestTest : public testing::Test {
};
// Verifies that extensions can access the correct keys.
-TEST_F(ManifestTest, Extension) {
+TEST_F(ManifestUnitTest, Extension) {
scoped_ptr<base::DictionaryValue> manifest_value(new base::DictionaryValue());
manifest_value->SetString(keys::kName, "extension");
manifest_value->SetString(keys::kVersion, "1");
@@ -117,7 +118,7 @@ TEST_F(ManifestTest, Extension) {
}
// Verifies that key restriction based on type works.
-TEST_F(ManifestTest, ExtensionTypes) {
+TEST_F(ManifestUnitTest, ExtensionTypes) {
scoped_ptr<base::DictionaryValue> value(new base::DictionaryValue());
value->SetString(keys::kName, "extension");
value->SetString(keys::kVersion, "1");
@@ -173,7 +174,7 @@ TEST_F(ManifestTest, ExtensionTypes) {
};
// Verifies that the getters filter restricted keys.
-TEST_F(ManifestTest, RestrictedKeys) {
+TEST_F(ManifestUnitTest, RestrictedKeys) {
scoped_ptr<base::DictionaryValue> value(new base::DictionaryValue());
value->SetString(keys::kName, "extension");
value->SetString(keys::kVersion, "1");

Powered by Google App Engine
This is Rietveld 408576698