chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc - Issue 572813002: Refactor ExtensionManifestTest to allow usage in src/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

Issue 572813002: Refactor ExtensionManifestTest to allow usage in src/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_update_unittest.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_web_accessible_resources_unittest.cc » ('j') | extensions/common/manifest_test.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

index 98b8b5ab4ebc4e3d6dafa0f6172a1f7a21897a49..11174b00ae3aaab57e9cba8c99e79b192a0c83d5 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

@@ -5,10 +5,10 @@

#include "base/memory/scoped_ptr.h"

#include "base/values.h"

#include "chrome/common/extensions/manifest_handlers/app_launch_info.h"

-#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"

+#include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"

#include "testing/gtest/include/gtest/gtest.h"

-typedef ExtensionManifestTest ValidAppManifestTest;

+typedef ChromeManifestTest ValidAppManifestTest;

TEST_F(ValidAppManifestTest, ValidApp) {

scoped_refptr<extensions::Extension> extension(

@@ -30,5 +30,5 @@ TEST_F(ValidAppManifestTest, AllowUnrecognizedPermissions) {

base::ListValue* permissions = NULL;

ASSERT_TRUE(manifest->GetList("permissions", &permissions));

permissions->Append(new base::StringValue("not-a-valid-permission"));

- LoadAndExpectSuccess(Manifest(manifest.get(), ""));

+ LoadAndExpectSuccess(ManifestData(manifest.get(), ""));

}