chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc - Issue 572813002: Refactor ExtensionManifestTest to allow usage in src/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

Issue 572813002: Refactor ExtensionManifestTest to allow usage in src/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_icons_unittest.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_isolatedapp_unittest.cc » ('j') | extensions/common/manifest_test.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

index 51c648ba31934ffabc43dcf34d1946454ba51c50..6807f8a1a3a535542fdbe2e777cbf041eb67765f 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

@@ -7,7 +7,7 @@

#include "base/path_service.h"

#include "base/strings/utf_string_conversions.h"

#include "chrome/common/chrome_paths.h"

-#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"

+#include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"

#include "components/crx_file/id_util.h"

#include "extensions/common/extension.h"

#include "extensions/common/manifest_constants.h"

@@ -28,7 +28,7 @@ const char kWhitelistID[] = "lmadimbbgapmngbiclpjjngmdickadpl";

namespace errors = manifest_errors;

namespace keys = manifest_keys;

-class InitValueManifestTest : public ExtensionManifestTest {

+class InitValueManifestTest : public ChromeManifestTest {

};

TEST_F(InitValueManifestTest, InitFromValueInvalid) {