Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8959)

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc

Issue 572813002: Refactor ExtensionManifestTest to allow usage in src/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc
index ae819d816e47427cdf77b76083e391ab5de1645e..b78180f945af222002980513b2f8d02b7b126477 100644
--- a/chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc
+++ b/chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
+#include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"
#include "base/command_line.h"
#include "base/memory/scoped_ptr.h"
@@ -20,7 +20,7 @@ namespace extensions {
namespace errors = manifest_errors;
namespace keys = manifest_keys;
-class ExtensionManifestBackgroundTest : public ExtensionManifestTest {
+class ExtensionManifestBackgroundTest : public ChromeManifestTest {
};
TEST_F(ExtensionManifestBackgroundTest, BackgroundPermission) {
@@ -35,7 +35,7 @@ TEST_F(ExtensionManifestBackgroundTest, BackgroundScripts) {
ASSERT_TRUE(manifest.get());
scoped_refptr<Extension> extension(
- LoadAndExpectSuccess(Manifest(manifest.get(), "")));
+ LoadAndExpectSuccess(ManifestData(manifest.get(), "")));
ASSERT_TRUE(extension.get());
const std::vector<std::string>& background_scripts =
BackgroundInfo::GetBackgroundScripts(extension.get());
@@ -49,7 +49,7 @@ TEST_F(ExtensionManifestBackgroundTest, BackgroundScripts) {
BackgroundInfo::GetBackgroundURL(extension.get()).path());
manifest->SetString("background_page", "monkey.html");
- LoadAndExpectError(Manifest(manifest.get(), ""),
+ LoadAndExpectError(ManifestData(manifest.get(), ""),
errors::kInvalidBackgroundCombination);
}
@@ -65,14 +65,14 @@ TEST_F(ExtensionManifestBackgroundTest, BackgroundPage) {
scoped_ptr<base::DictionaryValue> manifest(
LoadManifest("background_page_legacy.json", &error));
ASSERT_TRUE(manifest.get());
- extension = LoadAndExpectSuccess(Manifest(manifest.get(), ""));
+ extension = LoadAndExpectSuccess(ManifestData(manifest.get(), ""));
ASSERT_TRUE(extension.get());
EXPECT_EQ("/foo.html",
BackgroundInfo::GetBackgroundURL(extension.get()).path());
manifest->SetInteger(keys::kManifestVersion, 2);
LoadAndExpectWarning(
- Manifest(manifest.get(), ""),
+ ManifestData(manifest.get(), ""),
"'background_page' requires manifest version of 1 or lower.");
}
@@ -97,14 +97,14 @@ TEST_F(ExtensionManifestBackgroundTest, BackgroundPageWebRequest) {
manifest->SetBoolean(keys::kBackgroundPersistent, false);
manifest->SetInteger(keys::kManifestVersion, 2);
scoped_refptr<Extension> extension(
- LoadAndExpectSuccess(Manifest(manifest.get(), "")));
+ LoadAndExpectSuccess(ManifestData(manifest.get(), "")));
ASSERT_TRUE(extension.get());
EXPECT_TRUE(BackgroundInfo::HasLazyBackgroundPage(extension.get()));
base::ListValue* permissions = new base::ListValue();
permissions->Append(new base::StringValue("webRequest"));
manifest->Set(keys::kPermissions, permissions);
- LoadAndExpectError(Manifest(manifest.get(), ""),
+ LoadAndExpectError(ManifestData(manifest.get(), ""),
errors::kWebRequestConflictsWithLazyBackground);
}

Powered by Google App Engine
This is Rietveld 408576698