Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_update_unittest.cc

Issue 572813002: Refactor ExtensionManifestTest to allow usage in src/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 5 #include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"
6 #include "chrome/common/extensions/manifest_url_handler.h" 6 #include "chrome/common/extensions/manifest_url_handler.h"
7 #include "extensions/common/manifest_constants.h" 7 #include "extensions/common/manifest_constants.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 using extensions::Extension; 10 using extensions::Extension;
11 11
12 namespace errors = extensions::manifest_errors; 12 namespace errors = extensions::manifest_errors;
13 13
14 class UpdateURLManifestTest : public ExtensionManifestTest { 14 class UpdateURLManifestTest : public ChromeManifestTest {
15 }; 15 };
16 16
17 TEST_F(UpdateURLManifestTest, UpdateUrls) { 17 TEST_F(UpdateURLManifestTest, UpdateUrls) {
18 // Test several valid update urls 18 // Test several valid update urls
19 Testcase testcases[] = { 19 Testcase testcases[] = {
20 Testcase("update_url_valid_1.json", extensions::Manifest::INTERNAL, 20 Testcase("update_url_valid_1.json", extensions::Manifest::INTERNAL,
21 Extension::NO_FLAGS), 21 Extension::NO_FLAGS),
22 Testcase("update_url_valid_2.json", extensions::Manifest::INTERNAL, 22 Testcase("update_url_valid_2.json", extensions::Manifest::INTERNAL,
23 Extension::NO_FLAGS), 23 Extension::NO_FLAGS),
24 Testcase("update_url_valid_3.json", extensions::Manifest::INTERNAL, 24 Testcase("update_url_valid_3.json", extensions::Manifest::INTERNAL,
25 Extension::NO_FLAGS), 25 Extension::NO_FLAGS),
26 Testcase("update_url_valid_4.json", extensions::Manifest::INTERNAL, 26 Testcase("update_url_valid_4.json", extensions::Manifest::INTERNAL,
27 Extension::NO_FLAGS) 27 Extension::NO_FLAGS)
28 }; 28 };
29 RunTestcases(testcases, arraysize(testcases), 29 RunTestcases(testcases, arraysize(testcases),
30 EXPECT_TYPE_SUCCESS); 30 EXPECT_TYPE_SUCCESS);
31 31
32 // Test some invalid update urls 32 // Test some invalid update urls
33 Testcase testcases2[] = { 33 Testcase testcases2[] = {
34 Testcase("update_url_invalid_1.json", errors::kInvalidUpdateURL, 34 Testcase("update_url_invalid_1.json", errors::kInvalidUpdateURL,
35 extensions::Manifest::INTERNAL, Extension::NO_FLAGS), 35 extensions::Manifest::INTERNAL, Extension::NO_FLAGS),
36 Testcase("update_url_invalid_2.json", errors::kInvalidUpdateURL, 36 Testcase("update_url_invalid_2.json", errors::kInvalidUpdateURL,
37 extensions::Manifest::INTERNAL, Extension::NO_FLAGS), 37 extensions::Manifest::INTERNAL, Extension::NO_FLAGS),
38 Testcase("update_url_invalid_3.json", errors::kInvalidUpdateURL, 38 Testcase("update_url_invalid_3.json", errors::kInvalidUpdateURL,
39 extensions::Manifest::INTERNAL, Extension::NO_FLAGS) 39 extensions::Manifest::INTERNAL, Extension::NO_FLAGS)
40 }; 40 };
41 RunTestcases(testcases2, arraysize(testcases2), 41 RunTestcases(testcases2, arraysize(testcases2),
42 EXPECT_TYPE_ERROR); 42 EXPECT_TYPE_ERROR);
43 } 43 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698