Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc

Issue 572813002: Refactor ExtensionManifestTest to allow usage in src/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 6 #include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"
7 #include "chrome/common/url_constants.h" 7 #include "chrome/common/url_constants.h"
8 #include "extensions/common/error_utils.h" 8 #include "extensions/common/error_utils.h"
9 #include "extensions/common/extension.h" 9 #include "extensions/common/extension.h"
10 #include "extensions/common/manifest.h" 10 #include "extensions/common/manifest.h"
11 #include "extensions/common/manifest_constants.h" 11 #include "extensions/common/manifest_constants.h"
12 #include "extensions/common/permissions/permissions_data.h" 12 #include "extensions/common/permissions/permissions_data.h"
13 #include "extensions/common/switches.h" 13 #include "extensions/common/switches.h"
14 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
15 15
16 namespace extensions { 16 namespace extensions {
17 17
18 namespace errors = manifest_errors; 18 namespace errors = manifest_errors;
19 19
20 TEST_F(ExtensionManifestTest, ChromeURLPermissionInvalid) { 20 typedef ChromeManifestTest ChromePermissionManifestTest;
21
22 TEST_F(ChromePermissionManifestTest, ChromeURLPermissionInvalid) {
21 LoadAndExpectWarning("permission_chrome_url_invalid.json", 23 LoadAndExpectWarning("permission_chrome_url_invalid.json",
22 ErrorUtils::FormatErrorMessage( 24 ErrorUtils::FormatErrorMessage(
23 errors::kInvalidPermissionScheme, 25 errors::kInvalidPermissionScheme,
24 chrome::kChromeUINewTabURL)); 26 chrome::kChromeUINewTabURL));
25 } 27 }
26 28
27 TEST_F(ExtensionManifestTest, ChromeURLPermissionAllowedWithFlag) { 29 TEST_F(ChromePermissionManifestTest, ChromeURLPermissionAllowedWithFlag) {
28 // Ignore the policy delegate for this test. 30 // Ignore the policy delegate for this test.
29 PermissionsData::SetPolicyDelegate(NULL); 31 PermissionsData::SetPolicyDelegate(NULL);
30 CommandLine::ForCurrentProcess()->AppendSwitch( 32 CommandLine::ForCurrentProcess()->AppendSwitch(
31 switches::kExtensionsOnChromeURLs); 33 switches::kExtensionsOnChromeURLs);
32 std::string error; 34 std::string error;
33 scoped_refptr<Extension> extension = 35 scoped_refptr<Extension> extension =
34 LoadAndExpectSuccess("permission_chrome_url_invalid.json"); 36 LoadAndExpectSuccess("permission_chrome_url_invalid.json");
35 EXPECT_EQ("", error); 37 EXPECT_EQ("", error);
36 const GURL newtab_url(chrome::kChromeUINewTabURL); 38 const GURL newtab_url(chrome::kChromeUINewTabURL);
37 EXPECT_TRUE(extension->permissions_data()->CanAccessPage( 39 EXPECT_TRUE(extension->permissions_data()->CanAccessPage(
38 extension.get(), newtab_url, newtab_url, 0, -1, &error)) 40 extension.get(), newtab_url, newtab_url, 0, -1, &error))
39 << error; 41 << error;
40 } 42 }
41 43
42 TEST_F(ExtensionManifestTest, ChromeResourcesPermissionValidOnlyForComponents) { 44 TEST_F(ChromePermissionManifestTest,
45 ChromeResourcesPermissionValidOnlyForComponents) {
43 LoadAndExpectWarning("permission_chrome_resources_url.json", 46 LoadAndExpectWarning("permission_chrome_resources_url.json",
44 ErrorUtils::FormatErrorMessage( 47 ErrorUtils::FormatErrorMessage(
45 errors::kInvalidPermissionScheme, 48 errors::kInvalidPermissionScheme,
46 "chrome://resources/")); 49 "chrome://resources/"));
47 std::string error; 50 std::string error;
48 LoadExtension(Manifest("permission_chrome_resources_url.json"), 51 LoadExtension(ManifestData("permission_chrome_resources_url.json"),
49 &error, 52 &error,
50 extensions::Manifest::COMPONENT, 53 extensions::Manifest::COMPONENT,
51 Extension::NO_FLAGS); 54 Extension::NO_FLAGS);
52 EXPECT_EQ("", error); 55 EXPECT_EQ("", error);
53 } 56 }
54 57
55 } // namespace extensions 58 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698