Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 572803002: Fix an issue that video is not seekable (Closed)

Created:
6 years, 3 months ago by qinmin
Modified:
6 years, 3 months ago
Reviewers:
xhwang
CC:
chromium-reviews, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix an issue that video is not seekable When updating the ReadyState, HTMLMediaElement will immediately check the duration. If at that time has_valid_metadata_ is false, we will return NaN. So the has_valid_metadata_ has to be set before ReadyState is updated. BUG=414499 Committed: https://crrev.com/21f1f757864d7ec360ee1c7a00a6cb31d7af1231 Cr-Commit-Position: refs/heads/master@{#294979}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M content/renderer/media/android/webmediaplayer_android.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
qinmin
6 years, 3 months ago (2014-09-15 22:54:52 UTC) #2
qinmin
PTAL
6 years, 3 months ago (2014-09-15 22:54:59 UTC) #3
xhwang
lgtm % nit https://codereview.chromium.org/572803002/diff/1/content/renderer/media/android/webmediaplayer_android.cc File content/renderer/media/android/webmediaplayer_android.cc (right): https://codereview.chromium.org/572803002/diff/1/content/renderer/media/android/webmediaplayer_android.cc#newcode738 content/renderer/media/android/webmediaplayer_android.cc:738: has_valid_metadata_ = success; Add a comment ...
6 years, 3 months ago (2014-09-15 23:59:43 UTC) #4
qinmin
https://codereview.chromium.org/572803002/diff/1/content/renderer/media/android/webmediaplayer_android.cc File content/renderer/media/android/webmediaplayer_android.cc (right): https://codereview.chromium.org/572803002/diff/1/content/renderer/media/android/webmediaplayer_android.cc#newcode738 content/renderer/media/android/webmediaplayer_android.cc:738: has_valid_metadata_ = success; On 2014/09/15 23:59:43, xhwang wrote: > ...
6 years, 3 months ago (2014-09-16 00:30:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/572803002/20001
6 years, 3 months ago (2014-09-16 00:37:50 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 15a99e5add86d458fb93b47f2a2e71a98052a439
6 years, 3 months ago (2014-09-16 02:17:13 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 02:21:04 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/21f1f757864d7ec360ee1c7a00a6cb31d7af1231
Cr-Commit-Position: refs/heads/master@{#294979}

Powered by Google App Engine
This is Rietveld 408576698