Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 572763002: Use guest's existing GestureRecognizer instead of global one. (Closed)

Created:
6 years, 3 months ago by lazyboy
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, mkwst+moarreviews-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use guest's existing GestureRecognizer instead of global one. This makes touch events work in <webview>. Otherwise GestureRecognizer starts sending event to bogus Window*, which crashes the browser. BUG=413017 Test= In a touch enabled device, open a chrome app that has a <webview>. e.g. https://chrome.google.com/webstore/detail/edggnmnajhcbhlnpjnogkjpghaikidaa Try doing the following actions, none of them should crash the browser. 1. Tap on an input box, e.g. by going to http://www.google.com. 2. Scrolling a page should work. 3. Go to a page that has no touch handlers, you should be able to scroll the page w/o problem. 3. Go to a page that has touch handlers (e.g. touchstart), you should be able to scroll the page w/o problem. 4. Go to a page that has preventDefault() on touchstart event, you shouldn't be able to scroll the page. Committed: https://crrev.com/764ceed3b786f3e92fa39d547ae55b0082c0601e Cr-Commit-Position: refs/heads/master@{#294971}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
lazyboy
FYI, I'm trying to write interactive_ui_tests with EventGenerator, but so far no luck. Touch events ...
6 years, 3 months ago (2014-09-15 23:05:52 UTC) #2
sky
LGTM
6 years, 3 months ago (2014-09-15 23:19:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/572763002/1
6 years, 3 months ago (2014-09-16 00:01:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 23af0c89aae3da4df8a2f3a371d3ecf046352873
6 years, 3 months ago (2014-09-16 02:06:04 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 02:11:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/764ceed3b786f3e92fa39d547ae55b0082c0601e
Cr-Commit-Position: refs/heads/master@{#294971}

Powered by Google App Engine
This is Rietveld 408576698