Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: net/quic/quic_sent_packet_manager.cc

Issue 572703003: Minor change to QUIC's retransmission to not link old retransmissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@merge_75263809
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_sent_packet_manager.h ('k') | net/quic/quic_sent_packet_manager_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_sent_packet_manager.cc
diff --git a/net/quic/quic_sent_packet_manager.cc b/net/quic/quic_sent_packet_manager.cc
index e0f49377f4cab2df5fb761b812385eb792679064..1de5dac46e5ba83e16115bb73ed8147396b45bb0 100644
--- a/net/quic/quic_sent_packet_manager.cc
+++ b/net/quic/quic_sent_packet_manager.cc
@@ -310,17 +310,16 @@ bool QuicSentPacketManager::HasRetransmittableFrames(
}
void QuicSentPacketManager::RetransmitUnackedPackets(
- RetransmissionType retransmission_type) {
+ TransmissionType retransmission_type) {
+ DCHECK(retransmission_type == ALL_UNACKED_RETRANSMISSION ||
+ retransmission_type == ALL_INITIAL_RETRANSMISSION);
QuicPacketSequenceNumber sequence_number = unacked_packets_.GetLeastUnacked();
for (QuicUnackedPacketMap::const_iterator it = unacked_packets_.begin();
it != unacked_packets_.end(); ++it, ++sequence_number) {
const RetransmittableFrames* frames = it->retransmittable_frames;
- // TODO(ianswett): Consider adding a new retransmission type which removes
- // all these old packets from unacked and retransmits them as new sequence
- // numbers with no connection to the previous ones.
- if (frames != NULL && (retransmission_type == ALL_PACKETS ||
+ if (frames != NULL && (retransmission_type == ALL_UNACKED_RETRANSMISSION ||
frames->encryption_level() == ENCRYPTION_INITIAL)) {
- MarkForRetransmission(sequence_number, ALL_UNACKED_RETRANSMISSION);
+ MarkForRetransmission(sequence_number, retransmission_type);
}
}
}
« no previous file with comments | « net/quic/quic_sent_packet_manager.h ('k') | net/quic/quic_sent_packet_manager_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698