Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 572653003: DevTools: correctly close all async records when there are no subsequent top level records (Closed)

Created:
6 years, 3 months ago by yurys
Modified:
6 years, 3 months ago
Reviewers:
caseq, alph, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: correctly close all async records when there are no subsequent top level records BUG=405502 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181984

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -7 lines) Patch
M Source/devtools/front_end/timeline/TracingTimelineModel.js View 1 3 chunks +26 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
yurys
6 years, 3 months ago (2014-09-15 13:58:39 UTC) #2
caseq
https://codereview.chromium.org/572653003/diff/1/Source/devtools/front_end/timeline/TracingTimelineModel.js File Source/devtools/front_end/timeline/TracingTimelineModel.js (right): https://codereview.chromium.org/572653003/diff/1/Source/devtools/front_end/timeline/TracingTimelineModel.js#newcode363 Source/devtools/front_end/timeline/TracingTimelineModel.js:363: function copyChildrenToNextTop(top) { { => next line https://codereview.chromium.org/572653003/diff/1/Source/devtools/front_end/timeline/TracingTimelineModel.js#newcode364 Source/devtools/front_end/timeline/TracingTimelineModel.js:364: ...
6 years, 3 months ago (2014-09-15 14:07:41 UTC) #3
yurys
PTAL https://codereview.chromium.org/572653003/diff/1/Source/devtools/front_end/timeline/TracingTimelineModel.js File Source/devtools/front_end/timeline/TracingTimelineModel.js (right): https://codereview.chromium.org/572653003/diff/1/Source/devtools/front_end/timeline/TracingTimelineModel.js#newcode363 Source/devtools/front_end/timeline/TracingTimelineModel.js:363: function copyChildrenToNextTop(top) { On 2014/09/15 14:07:41, caseq wrote: ...
6 years, 3 months ago (2014-09-15 14:36:45 UTC) #4
caseq
lgtm
6 years, 3 months ago (2014-09-15 14:37:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/572653003/20001
6 years, 3 months ago (2014-09-15 14:38:38 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 15:43:28 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 181984

Powered by Google App Engine
This is Rietveld 408576698