tools/telemetry/telemetry/core/platform/power_monitor/monsoon_power_monitor.py - Issue 572643002: telemetry: Fix runaway subprocess in monsoon_power_monitor.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/power_monitor/monsoon_power_monitor.py

Issue 572643002: telemetry: Fix runaway subprocess in monsoon_power_monitor.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Fix email address in AUTHORS Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/platform/power_monitor/monsoon_power_monitor.py

diff --git a/tools/telemetry/telemetry/core/platform/power_monitor/monsoon_power_monitor.py b/tools/telemetry/telemetry/core/platform/power_monitor/monsoon_power_monitor.py

index b2bf0fdf20eeedce91773264f47c34351c28baef..eb9e9d97eb4ce5f475f054784c7d1642c575a498 100644

--- a/tools/telemetry/telemetry/core/platform/power_monitor/monsoon_power_monitor.py

+++ b/tools/telemetry/telemetry/core/platform/power_monitor/monsoon_power_monitor.py

@@ -73,6 +73,8 @@ class MonsoonPowerMonitor(sysfs_power_monitor.SysfsPowerMonitor):

args=(self._monsoon,

self._is_collecting,

self._powermonitor_output_file))

+ # Ensure child is not left behind: parent kills daemonic children on exit.

+ self._powermonitor_process.daemon = 1

achuithb 2014/09/17 13:37:58 True? Isn't this a Boolean?

v.putkinen 2014/09/18 07:33:54 It is, good catch. I'll send a fixed patch set wit

self._powermonitor_process.start()

if not self._is_collecting.wait(timeout=0.5):

self._powermonitor_process.terminate()

« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »