Enable webview tag in webui

Enable webview tag in whitelisted webui pages, following the example of <extensionoptions>.

Only whitelisted webUIs could embed webview tag, specifically, they have to be declared in _api_features.json and they have to relax CSP to allow internal browser plugins.

BUG=

Committed: https://crrev.com/6dca78447b0a307b939238a6537d2ca668a559bd
Cr-Commit-Position: refs/heads/master@{#296251}

[guohui, 2014-09-18 22:25:03]

Patchset #1 (id:1) has been deleted

[guohui, 2014-09-18 22:35:44]

guohui@chromium.org changed reviewers:
+ fsamuel@chromium.org

[guohui, 2014-09-18 22:35:44]

Hey Fady,

could you please take a look at the CL?

Thanks,

Hui

[guohui, 2014-09-18 22:38:58]

On 2014/09/18 22:35:44, guohui wrote:
> Hey Fady,
> 
> could you please take a look at the CL?
> 
> Thanks,
> 
> Hui

I only checked that chrome://chrome-signin could successfully embed webview tag,
without verifying each webview API, more changes may be required to fully
support all webview APIs in webUI.

[Fady Samuel, 2014-09-18 22:42:46]

Please also update chromeWebViewInternal:

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/exte...

Thanks!

[Fady Samuel, 2014-09-19 20:25:26]

Sorry, I missed your change, lgtm.

[guohui, 2014-09-22 18:49:15]

guohui@chromium.org changed reviewers:
+ rockot@chromium.org

[guohui, 2014-09-22 18:49:15]

+rockot@ for owner review of _api_features.json

[guohui, 2014-09-22 18:51:06]

Patchset #2 (id:40001) has been deleted

[Ken Rockot(use gerrit already), 2014-09-22 20:47:33]

Generally looks OK, but I have no context for why these features are being
turned off in component extensions. Could you please explain this?

https://codereview.chromium.org/572633003/diff/60001/chrome/common/extensions...
File chrome/common/extensions/api/_api_features.json (left):

https://codereview.chromium.org/572633003/diff/60001/chrome/common/extensions...
chrome/common/extensions/api/_api_features.json:734: "dependencies":
["permission:webview"],
Why are you replacing this feature instead of just adding another entry to
webRequestInternal?

https://codereview.chromium.org/572633003/diff/60001/chrome/common/extensions...
chrome/common/extensions/api/_api_features.json:768: // Component extensions can
use the webViewRequest API from iframes.
Same question - why are you replacing an existing feature?

https://codereview.chromium.org/572633003/diff/60001/extensions/common/api/_a...
File extensions/common/api/_api_features.json (left):

https://codereview.chromium.org/572633003/diff/60001/extensions/common/api/_a...
extensions/common/api/_api_features.json:76: // Component extensions can use the
guestViewInternal API from iframes.
Why are you deleting this feature?

https://codereview.chromium.org/572633003/diff/60001/extensions/common/api/_a...
extensions/common/api/_api_features.json:255: // Component extensions can use
the webViewInternal API from iframes.
And this one?

https://codereview.chromium.org/572633003/diff/60001/extensions/common/api/_a...
File extensions/common/api/_api_features.json (right):

https://codereview.chromium.org/572633003/diff/60001/extensions/common/api/_a...
extensions/common/api/_api_features.json:79: "matches":
["chrome://extensions-frame/*",
formatting nit: All other instances of multiline collections in features files
use the format:

  "foo": [
    "bar",
    "baz"
  ]

Please do this here.

[guohui, 2014-09-22 20:58:59]

https://codereview.chromium.org/572633003/diff/60001/chrome/common/extensions...
File chrome/common/extensions/api/_api_features.json (left):

https://codereview.chromium.org/572633003/diff/60001/chrome/common/extensions...
chrome/common/extensions/api/_api_features.json:734: "dependencies":
["permission:webview"],
On 2014/09/22 20:47:32, Ken Rockot wrote:
> Why are you replacing this feature instead of just adding another entry to
> webRequestInternal?

because i added this feature for some old code that has been removed, and will
be replaced by a pure webui-based implementation.

https://codereview.chromium.org/572633003/diff/60001/chrome/common/extensions...
chrome/common/extensions/api/_api_features.json:768: // Component extensions can
use the webViewRequest API from iframes.
On 2014/09/22 20:47:32, Ken Rockot wrote:
> Same question - why are you replacing an existing feature?

same as above.

https://codereview.chromium.org/572633003/diff/60001/extensions/common/api/_a...
File extensions/common/api/_api_features.json (left):

https://codereview.chromium.org/572633003/diff/60001/extensions/common/api/_a...
extensions/common/api/_api_features.json:76: // Component extensions can use the
guestViewInternal API from iframes.
On 2014/09/22 20:47:33, Ken Rockot wrote:
> Why are you deleting this feature?

same as i explained in the other file, i added this feature for some old code
(embed webview in a component extension that is in turn embedded in a webui
page) that has been completely removed.

https://codereview.chromium.org/572633003/diff/60001/extensions/common/api/_a...
extensions/common/api/_api_features.json:255: // Component extensions can use
the webViewInternal API from iframes.
On 2014/09/22 20:47:32, Ken Rockot wrote:
> And this one?

same as above.

https://codereview.chromium.org/572633003/diff/60001/extensions/common/api/_a...
File extensions/common/api/_api_features.json (right):

https://codereview.chromium.org/572633003/diff/60001/extensions/common/api/_a...
extensions/common/api/_api_features.json:79: "matches":
["chrome://extensions-frame/*",
On 2014/09/22 20:47:33, Ken Rockot wrote:
> formatting nit: All other instances of multiline collections in features files
> use the format:
> 
>   "foo": [
>     "bar",
>     "baz"
>   ]
> 
> Please do this here.

Done.

[Ken Rockot(use gerrit already), 2014-09-22 21:15:32]

OK - As long as no existing component extensions are depending on this behavior,
LGTM

[guohui, 2014-09-22 21:19:38]

The CQ bit was checked by guohui@chromium.org

[commit-bot: I haz the power, 2014-09-22 21:21:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/572633003/80001

[commit-bot: I haz the power, 2014-09-22 21:26:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-22 21:26:03]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/59179)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[guohui, 2014-09-23 18:43:37]

The CQ bit was checked by guohui@chromium.org

[commit-bot: I haz the power, 2014-09-23 20:30:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/572633003/100001

[commit-bot: I haz the power, 2014-09-23 21:21:29]

Committed patchset #4 (id:100001) as 318dff34d2f1ccd89eccadde3a1fb61e605af07f

[commit-bot: I haz the power, 2014-09-23 21:22:09]

Patchset 4 (id:??) landed as
https://crrev.com/6dca78447b0a307b939238a6537d2ca668a559bd
Cr-Commit-Position: refs/heads/master@{#296251}