Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 572613002: gtest, gmock: pull older versions via DEPS that don’t require C++11 library support (Closed)

Created:
6 years, 3 months ago by Mark Mentovai
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

gtest, gmock: pull older versions via DEPS that don’t require C++11 library support. When building with support for Mac OS X 10.6, C++11 library support is not available, because Mac OS X uses libc++ for C++11 support, and Mac OS X 10.6 does not provide libc++ as a runtime library. gtest and gmock have a hard time distinguishing between C++11 language and library support (which is not really their fault, having one but not the other is an odd situation). The currently-released trunk versions of gtest and gmock do not work in this configuration. I’ve submitted patches upstream to fix this, but they may take a while to make it to the released verions. For now, it’s fine to roll gtest and gmock back to versions from December 2013 that do work cleanly with C++11 language support but only C++03 library support. TEST=Compile and run all tests in both 10.6 and native builds R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/b6a0183ccec78a13b1fb42a1a0298ef75f0520eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years, 3 months ago (2014-09-15 04:02:47 UTC) #2
Robert Sesek
LGTM
6 years, 3 months ago (2014-09-15 18:17:15 UTC) #3
Mark Mentovai
6 years, 3 months ago (2014-09-15 19:09:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as b6a0183 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698