Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(322)

Issue 5726005: Make idle notification cleanup less aggressive. Do not clean up on... (Closed)

Created:
7 years ago by Mads Ager (chromium)
Modified:
6 years, 7 months ago
Reviewers:
antonm, Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Make idle notification cleanup less aggressive. Do not clean up on idle notifications after the one that causes the mark-compact collection unless four or more garbage collections (scavenges) have occurred. The embedder should stop sending idle notifications once V8 returns true from the IdleNotification call. This change is being defensive so it will not hurt as badly if embedders continue to send idle notifications. Committed: http://code.google.com/p/v8/source/detail?r=5981

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M src/heap.cc View 1 4 chunks +14 lines, -4 lines 0 comments Download
Trybot results:

Messages

Total messages: 5 (0 generated)
Mads Ager (chromium)
7 years ago (2010-12-13 11:34:09 UTC) #1
Kasper Lund
http://codereview.chromium.org/5726005/diff/1/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/5726005/diff/1/src/heap.cc#newcode3783 src/heap.cc:3783: if (number_idle_notifications > kIdlesBeforeMarkCompact) return true; Have you consider ...
7 years ago (2010-12-13 11:45:44 UTC) #2
Mads Ager (chromium)
http://codereview.chromium.org/5726005/diff/1/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/5726005/diff/1/src/heap.cc#newcode3783 src/heap.cc:3783: if (number_idle_notifications > kIdlesBeforeMarkCompact) return true; On 2010/12/13 11:45:44, ...
7 years ago (2010-12-13 11:58:06 UTC) #3
antonm
LGTM http://codereview.chromium.org/5726005/diff/1/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/5726005/diff/1/src/heap.cc#newcode3760 src/heap.cc:3760: static const int kMaxIdleCount = 9; do we ...
7 years ago (2010-12-13 12:06:20 UTC) #4
Mads Ager (chromium)
7 years ago (2010-12-13 12:12:58 UTC) #5
http://codereview.chromium.org/5726005/diff/1/src/heap.cc
File src/heap.cc (right):

http://codereview.chromium.org/5726005/diff/1/src/heap.cc#newcode3760
src/heap.cc:3760: static const int kMaxIdleCount = 9;
On 2010/12/13 12:06:20, antonm wrote:
> do we need it at all?  maybe use something like kIdlesBeforeMarkCompact (+1)
> instead?

I'm just being paranoid to avoid overflows. I'll change it to
kIdlesBeforeMarkCompact + 1.

Thanks.

Powered by Google App Engine
This is Rietveld 0eb02b776