Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 572593002: Revert of Clean up GestureEventDetails constructors (Closed)

Created:
6 years, 3 months ago by nhiroki
Modified:
6 years, 3 months ago
CC:
chromium-reviews, tdanderson+views_chromium.org, sadrul, dyu1, tfarina, benquan, Ilya Sherman, jdduke+watch_chromium.org, tdresser+watch_chromium.org, jam, dcheng, ben+aura_chromium.org, darin-cc_chromium.org, Dane Wallinga, oshima+watch_chromium.org, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org, kalyank, ben+views_chromium.org, ben+corewm_chromium.org, stevenjb+watch_chromium.org, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Clean up GestureEventDetails constructors (patchset #4 id:100001 of https://codereview.chromium.org/565583005/) Reason for revert: This seems to fail the following tests in "athena_unittests" on "Linux ChromiumOS Tests (dbg)(3)" - HomeCardGestureManagerTest.Basic - HomeCardGestureManagerTest.StartCentered http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/36778 Original issue's description: > Clean up GestureEventDetails' constructors. > > In one of the GestureEventDetails' constructors, the arguments > delta_x, delta_y sometime are not used, so we should make a new > constructor which only takes one argument EventType. > > BUG=350942 > > Committed: https://crrev.com/b5e408e7bffd3d1e6b60612f65c0538a90329c59 > Cr-Commit-Position: refs/heads/master@{#294760} TBR=tdresser@chromium.org,jdduke@chromium.org,sadrul@chromium.org,sky@chromium.org,lanwei@chromium.org NOTREECHECKS=true NOTRY=true BUG=350942 Committed: https://crrev.com/bedd69525d5dd70a953f7a8a49089de0d66fe148 Cr-Commit-Position: refs/heads/master@{#294776}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -171 lines) Patch
M ash/drag_drop/drag_drop_controller.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M ash/drag_drop/drag_drop_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_tooltip_manager_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/overview/overview_button_tray_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_popup_base_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/desktop_media_picker_views_unittest.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M content/browser/renderer_host/input/gesture_text_selector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura_browsertest.cc View 5 chunks +10 lines, -7 lines 0 comments Download
M ui/aura/remote_window_tree_host_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_event_dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gesture_detection/gesture_event_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gesture_detection/gesture_event_data_packet_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gesture_detection/gesture_provider.cc View 7 chunks +8 lines, -11 lines 0 comments Download
M ui/events/gesture_detection/touch_disposition_gesture_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gesture_event_details.h View 2 chunks +0 lines, -7 lines 0 comments Download
M ui/events/gesture_event_details.cc View 3 chunks +18 lines, -8 lines 0 comments Download
M ui/events/test/event_generator.cc View 1 chunk +5 lines, -1 line 0 comments Download
M ui/views/controls/button/custom_button_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/table/table_view_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/views/controls/textfield/textfield_unittest.cc View 7 chunks +22 lines, -24 lines 0 comments Download
M ui/views/corewm/desktop_capture_controller_unittest.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl_unittest.cc View 5 chunks +25 lines, -15 lines 0 comments Download
M ui/views/view_targeter_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M ui/views/widget/root_view_unittest.cc View 6 chunks +36 lines, -18 lines 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 8 chunks +32 lines, -26 lines 0 comments Download
M ui/wm/core/user_activity_detector_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nhiroki
Created Revert of Clean up GestureEventDetails constructors
6 years, 3 months ago (2014-09-15 01:48:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/572593002/1
6 years, 3 months ago (2014-09-15 01:49:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 02152ced24411e8411309a70cd31fd99918882a5
6 years, 3 months ago (2014-09-15 01:51:31 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 01:54:03 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bedd69525d5dd70a953f7a8a49089de0d66fe148
Cr-Commit-Position: refs/heads/master@{#294776}

Powered by Google App Engine
This is Rietveld 408576698