Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2500)

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/background/accessibility_api_handler.js

Issue 572373002: Refactor tabs API handlers out of AccessibilityApiHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Getting out of a bind. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/chromevox/background/background.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/chromevox/chromevox/background/accessibility_api_handler.js
diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/background/accessibility_api_handler.js b/chrome/browser/resources/chromeos/chromevox/chromevox/background/accessibility_api_handler.js
index 54a3a9ab0b348a5202bbd5dbba689fd09cff9f51..c015b6d9be3c57926467dd1b1a01969ca3119b6c 100644
--- a/chrome/browser/resources/chromeos/chromevox/chromevox/background/accessibility_api_handler.js
+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/background/accessibility_api_handler.js
@@ -5,7 +5,6 @@
/**
* @fileoverview Accesses Chrome's accessibility extension API and gives
* spoken feedback for events that happen in the "Chrome of Chrome".
- *
*/
goog.provide('cvox.AccessibilityApiHandler');
@@ -175,24 +174,6 @@ cvox.AccessibilityApiHandler.prototype.addEventListeners_ = function() {
var accessibility = chrome.accessibilityPrivate;
- chrome.tabs.onCreated.addListener(goog.bind(function(tab) {
- if (!cvox.ChromeVox.isActive) {
- return;
- }
- this.tts.speak(msg('chrome_tab_created'),
- 0,
- cvox.AbstractTts.PERSONALITY_ANNOUNCEMENT);
- this.braille.write(cvox.NavBraille.fromText(msg('chrome_tab_created')));
- this.earcons.playEarcon(cvox.AbstractEarcons.OBJECT_OPEN);
- }, this));
-
- chrome.tabs.onRemoved.addListener(goog.bind(function(tab) {
- if (!cvox.ChromeVox.isActive) {
- return;
- }
- this.earcons.playEarcon(cvox.AbstractEarcons.OBJECT_CLOSE);
- }, this));
-
chrome.tabs.onActivated.addListener(goog.bind(function(activeInfo) {
if (!cvox.ChromeVox.isActive) {
return;
@@ -201,55 +182,10 @@ cvox.AccessibilityApiHandler.prototype.addEventListeners_ = function() {
if (tab.status == 'loading') {
return;
}
- var title = tab.title ? tab.title : tab.url;
- this.tts.speak(msg('chrome_tab_selected',
- [title]),
- cvox.AbstractTts.QUEUE_MODE_FLUSH,
- cvox.AbstractTts.PERSONALITY_ANNOUNCEMENT);
- this.braille.write(
- cvox.NavBraille.fromText(msg('chrome_tab_selected', [title])));
- this.earcons.playEarcon(cvox.AbstractEarcons.OBJECT_SELECT);
this.queueAlertsForActiveTab();
}, this));
}, this));
- chrome.tabs.onUpdated.addListener(goog.bind(function(tabId, selectInfo) {
- if (!cvox.ChromeVox.isActive) {
- return;
- }
- chrome.tabs.get(tabId, goog.bind(function(tab) {
- if (!tab.active) {
- return;
- }
- if (tab.status == 'loading') {
- this.earcons.playEarcon(cvox.AbstractEarcons.BUSY_PROGRESS_LOOP);
- } else {
- this.earcons.playEarcon(cvox.AbstractEarcons.TASK_SUCCESS);
- }
- }, this));
- }, this));
-
- chrome.windows.onFocusChanged.addListener(goog.bind(function(windowId) {
- if (!cvox.ChromeVox.isActive) {
- return;
- }
- if (windowId == chrome.windows.WINDOW_ID_NONE) {
- return;
- }
- chrome.windows.get(windowId, goog.bind(function(window) {
- chrome.tabs.getSelected(windowId, goog.bind(function(tab) {
- var msgId = window.incognito ? 'chrome_incognito_window_selected' :
- 'chrome_normal_window_selected';
- var title = tab.title ? tab.title : tab.url;
- this.tts.speak(msg(msgId, [title]),
- cvox.AbstractTts.QUEUE_MODE_FLUSH,
- cvox.AbstractTts.PERSONALITY_ANNOUNCEMENT);
- this.braille.write(cvox.NavBraille.fromText(msg(msgId, [title])));
- this.earcons.playEarcon(cvox.AbstractEarcons.OBJECT_SELECT);
- }, this));
- }, this));
- }, this));
-
chrome.accessibilityPrivate.onWindowOpened.addListener(
goog.bind(function(win) {
if (!cvox.ChromeVox.isActive) {
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/chromevox/background/background.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698