Drop 10.5 support: use ServiceManagement.framework directly

Drop 10.5 support: use ServiceManagement.framework directly.

TEST=util_test ServiceManagement.SubmitRemoveJob
R=rsesek@chromium.org

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/63fd3ae47d2513ef4390c3d8c0dde3fa95152480

[Mark Mentovai, 2014-09-16 15:40:56]

mark@chromium.org changed reviewers:
+ rsesek@chromium.org

[Mark Mentovai, 2014-09-16 15:40:57]

Apple fixed radar 17365104 in 10.10DP7 14A343f, so I took another look at this.
I found that there are other areas where 10.5 would require additional help, so
I decided to just drop it altogether.

I’m keeping this change isolated from the rest of the parts that drop 10.5
support (https://codereview.chromium.org/575823002) because with the deprecated
state of ServiceManagement.framework, it’s possible that we’ll need to bring
back the launchd support code in the future. Keeping this isolated could make
that easier. However, launch_msg() is deprecated too, so maybe not…

[Robert Sesek, 2014-09-16 16:00:26]

https://codereview.chromium.org/572323002/diff/1/util/mac/service_management.cc
File util/mac/service_management.cc (right):

https://codereview.chromium.org/572323002/diff/1/util/mac/service_management....
util/mac/service_management.cc:36: #pragma GCC diagnostic push
Does clang interpret this GCC pragma and do the same?

[Mark Mentovai, 2014-09-16 21:39:02]

https://codereview.chromium.org/572323002/diff/1/util/mac/service_management.cc
File util/mac/service_management.cc (right):

https://codereview.chromium.org/572323002/diff/1/util/mac/service_management....
util/mac/service_management.cc:36: #pragma GCC diagnostic push
rsesek wrote:
> Does clang interpret this GCC pragma and do the same?

Yes.

But GCC doesn’t (or at least didn’t) interpret the clang pragma, so I use GCC to
catch both compilers.

[Robert Sesek, 2014-09-16 21:40:17]

LGTM. Did you change the other instance of that (or did you just delete it with
the bootstrap file)?

[Mark Mentovai, 2014-09-16 21:44:14]

The other instance in the bootstrap file always said “pragma GCC” but it’s gone
now that that file is gone.

[Mark Mentovai, 2014-09-16 21:45:44]

Committed patchset #1 (id:1) manually as 63fd3ae (presubmit successful).