Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Issue 572293002: Track how much we miss the idle notification limit (Closed)

Created:
6 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 3 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Track how much we miss the idle notification limit We can't report negative values using histograms, so we split the data up into two histograms BUG=chromium:397026 LOG=n R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23981

Patch Set 1 #

Patch Set 2 : updates #

Total comments: 2

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M src/counters.h View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M src/heap/heap.cc View 1 2 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
6 years, 3 months ago (2014-09-16 13:32:14 UTC) #1
Hannes Payer (out of office)
LGTM, two nits https://codereview.chromium.org/572293002/diff/20001/src/counters.h File src/counters.h (right): https://codereview.chromium.org/572293002/diff/20001/src/counters.h#newcode297 src/counters.h:297: HR(gc_idle_time_limit_exceeded, V8.GCIdleTimeLimitExceeded, 0, 10000, 101) \ ...
6 years, 3 months ago (2014-09-16 14:29:34 UTC) #2
Hannes Payer (out of office)
LGTM, two nits https://codereview.chromium.org/572293002/diff/20001/src/counters.h File src/counters.h (right): https://codereview.chromium.org/572293002/diff/20001/src/counters.h#newcode297 src/counters.h:297: HR(gc_idle_time_limit_exceeded, V8.GCIdleTimeLimitExceeded, 0, 10000, 101) \ ...
6 years, 3 months ago (2014-09-16 14:29:35 UTC) #3
jochen (gone - plz use gerrit)
6 years, 3 months ago (2014-09-16 16:18:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 23981 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698