Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(712)

Issue 5722007: Merge 73605 - 2010-12-07 Jeremy Orlow <jorlow@chromium.org>... (Closed)

Created:
8 years, 6 months ago by hans
Modified:
7 years, 12 months ago
Reviewers:
jorlow
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/597/
Visibility:
Public.

Description

Merge 73605 - 2010-12-07 Jeremy Orlow <jorlow@chromium.org>; Reviewed by Steve Block. IndexedDB returns the wrong exceptions https://bugs.webkit.org/show_bug.cgi?id=50632 * storage/indexeddb/constants-expected.txt: * storage/indexeddb/constants.html: * storage/indexeddb/objectstore-removeobjectstore-expected.txt: * storage/indexeddb/objectstore-removeobjectstore.html: 2010-12-07 Jeremy Orlow <jorlow@chromium.org>; Reviewed by Steve Block. IndexedDB returns the wrong exceptions https://bugs.webkit.org/show_bug.cgi?id=50632 IndexedDB exceptions need to have an offset so they can be distinguished from DOM exceptions. We also need to add strings for the various exceptions. Lastly, make IDBDatabaseException use the common exception base class. * bindings/js/JSDOMBinding.cpp: (WebCore::setDOMException): * bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setDOMException): * dom/ExceptionCode.cpp: (WebCore::getExceptionCodeDescription): * dom/ExceptionCode.h: * storage/IDBDatabaseError.h: (WebCore::IDBDatabaseError::code): * storage/IDBDatabaseException.h: (WebCore::IDBDatabaseException::create): (WebCore::IDBDatabaseException::ErrorCodeToExceptionCode): (WebCore::IDBDatabaseException::IDBDatabaseException): * storage/IDBDatabaseException.idl: TBR=jorlow@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73910

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -69 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +13 lines, -1 line 0 comments Download
M LayoutTests/storage/indexeddb/constants.html View 1 chunk +10 lines, -10 lines 0 comments Download
M LayoutTests/storage/indexeddb/constants-expected.txt View 1 chunk +10 lines, -10 lines 0 comments Download
M LayoutTests/storage/indexeddb/objectstore-removeobjectstore.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/storage/indexeddb/objectstore-removeobjectstore-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M WebCore/ChangeLog View 1 chunk +28 lines, -1 line 0 comments Download
M WebCore/bindings/js/JSDOMBinding.cpp View 2 chunks +10 lines, -0 lines 0 comments Download
M WebCore/bindings/v8/V8Proxy.cpp View 3 chunks +10 lines, -0 lines 0 comments Download
M WebCore/dom/ExceptionCode.h View 1 chunk +3 lines, -0 lines 0 comments Download
M WebCore/dom/ExceptionCode.cpp View 3 chunks +41 lines, -0 lines 0 comments Download
M WebCore/storage/IDBDatabaseError.h View 2 chunks +2 lines, -1 line 0 comments Download
M WebCore/storage/IDBDatabaseException.h View 1 chunk +31 lines, -29 lines 0 comments Download
M WebCore/storage/IDBDatabaseException.idl View 1 chunk +22 lines, -15 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
hans
8 years, 6 months ago (2010-12-13 13:49:09 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698