Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.h

Issue 572163002: Deprecate Safe Browsing timing histograms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/safe_browsing_blocking_page.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.h
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h b/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
index 567cac47ef0765afe2bf7c296cb3f6184575854e..4fcc932debe4ce9b83c3eab01716bb35f8f80947 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
@@ -139,11 +139,6 @@ class SafeBrowsingBlockingPage : public content::InterstitialPageDelegate {
// Used to query the HistoryService to see if the URL is in history. For UMA.
void OnGotHistoryCount(bool success, int num_visits, base::Time first_visit);
- // Records the time it took for the user to react to the
- // interstitial. We won't double-count if this method is called
- // multiple times.
- void RecordUserReactionTime(const std::string& command);
-
// Checks if we should even show the malware details option. For example, we
// don't show it in incognito mode.
bool CanShowMalwareDetailsOption();
@@ -204,12 +199,6 @@ class SafeBrowsingBlockingPage : public content::InterstitialPageDelegate {
GURL url_;
content::InterstitialPage* interstitial_page_; // Owns us
- // Time when the interstitial was show. This variable is set in
- // GetHTMLContents() which is called right before the interstitial
- // is shown to the user. Will return is_null() once we reported the
- // user action.
- base::TimeTicks interstitial_show_time_;
-
// Whether the user has expanded the "see more" section of the page already
// during this interstitial page.
bool has_expanded_see_more_section_;
mattm 2014/09/16 07:29:54 Can remove this too?
felt 2014/09/16 14:56:35 Done.
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/safe_browsing_blocking_page.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698