Fix sync settings metric

Fix sync settings metric

Metric exists but is spelled wrong in JS.

R=tim@chromium.org,estade@chromium.org

Committed: https://crrev.com/d95e2fff51aa5085610a7407cd04f83eab87c816
Cr-Commit-Position: refs/heads/master@{#296578}

[michaelpg, 2014-09-15 23:12:23]

michaelpg@chromium.org changed reviewers:
- stevenjb@chromium.org

[michaelpg, 2014-09-15 23:12:52]

michaelpg@chromium.org changed reviewers:
+ tim@chromium.org

[stevenjb, 2014-09-15 23:25:35]

stevenjb@chromium.org changed reviewers:
+ stevenjb@chromium.org

[stevenjb, 2014-09-15 23:25:36]

lgtm

[michaelpg, 2014-09-24 01:39:15]

ping: timsteele: want to get this in before the branch. tiny.

[stevenjb, 2014-09-24 15:52:41]

I think you can safely TBR this and commit it.

[michaelpg, 2014-09-24 22:36:32]

michaelpg@chromium.org changed reviewers:
+ estade@chromium.org

[michaelpg, 2014-09-24 22:37:48]

On 2014/09/24 15:52:41, stevenjb wrote:
> I think you can safely TBR this and commit it.

I prefer to follow "TBR should never be used for: -really simple changes that
you think don't need to be reviewed" from
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/2ddB1maCrgg/zr-Ku...

+estade@ for OWNERS review

[Evan Stade, 2014-09-24 22:52:28]

lgtm

[michaelpg, 2014-09-24 22:56:12]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2014-09-24 22:57:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/572113002/1

[commit-bot: I haz the power, 2014-09-24 23:55:26]

Committed patchset #1 (id:1) as ba5c14f7e54a1ab74d01faf6618600f534f734e1

[commit-bot: I haz the power, 2014-09-24 23:55:58]

Patchset 1 (id:??) landed as
https://crrev.com/d95e2fff51aa5085610a7407cd04f83eab87c816
Cr-Commit-Position: refs/heads/master@{#296578}

[stevenjb, 2014-09-25 15:32:02]

So, just for future reference, the critical part of that paragraph is,
"Please never land a change that hasn't been reviewed". That is absolutely
correct, TBR should not be used in lieu of a review. However, this was
reviewed, and the OWNERS system is imperfect. Good judgement can be used
there.

On Wed, Sep 24, 2014 at 4:37 PM, <michaelpg@chromium.org> wrote:

> On 2014/09/24 15:52:41, stevenjb wrote:
>
>> I think you can safely TBR this and commit it.
>>
>
> I prefer to follow "TBR should never be used for: -really simple changes
> that
> you think don't need to be reviewed" from
> https://groups.google.com/a/chromium.org/d/msg/chromium-
> dev/2ddB1maCrgg/zr-KurM7AsEJ
>
> +estade@ for OWNERS review
>
> https://codereview.chromium.org/572113002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.