Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2353)

Unified Diff: chrome/browser/signin/easy_unlock_screenlock_state_handler.cc

Issue 572083004: Don't use opaque icons for easy unlock (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/easy_unlock_screenlock_state_handler.cc
diff --git a/chrome/browser/signin/easy_unlock_screenlock_state_handler.cc b/chrome/browser/signin/easy_unlock_screenlock_state_handler.cc
index a2b608384f62f2d268ee7f730316234d40aac8e8..0b8cd496ae8cd628d448c37956a19a17d38ea641 100644
--- a/chrome/browser/signin/easy_unlock_screenlock_state_handler.cc
+++ b/chrome/browser/signin/easy_unlock_screenlock_state_handler.cc
@@ -16,7 +16,6 @@
namespace {
size_t kIconSize = 27u;
-size_t kOpaqueIconOpacity = 50u;
size_t kSpinnerResourceWidth = 1215u;
size_t kSpinnerIntervalMs = 50u;
@@ -39,14 +38,6 @@ std::string GetIconURLForState(EasyUnlockScreenlockStateHandler::State state) {
}
}
-bool UseOpaqueIcon(EasyUnlockScreenlockStateHandler::State state) {
- return state == EasyUnlockScreenlockStateHandler::STATE_NO_BLUETOOTH ||
- state == EasyUnlockScreenlockStateHandler::STATE_NO_PHONE ||
- state == EasyUnlockScreenlockStateHandler::STATE_PHONE_NOT_NEARBY ||
- state == EasyUnlockScreenlockStateHandler::STATE_PHONE_UNLOCKABLE ||
- state == EasyUnlockScreenlockStateHandler::STATE_PHONE_UNSUPPORTED;
-}
-
bool HasAnimation(EasyUnlockScreenlockStateHandler::State state) {
return state == EasyUnlockScreenlockStateHandler::STATE_BLUETOOTH_CONNECTING;
}
@@ -135,9 +126,6 @@ void EasyUnlockScreenlockStateHandler::ChangeState(State new_state) {
UpdateTooltipOptions(trial_run, &icon_options);
- if (UseOpaqueIcon(state_))
- icon_options.SetOpacity(kOpaqueIconOpacity);
-
icon_options.SetSize(kIconSize, kIconSize);
if (HasAnimation(state_))
« no previous file with comments | « no previous file | chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698