Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 572083004: Don't use opaque icons for easy unlock (Closed)

Created:
6 years, 3 months ago by tbarzic
Modified:
6 years, 3 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't use opaque icons for easy unlock BUG=414488 Committed: https://crrev.com/8f7d3c09bfb7efb3e3b30e0cba1b0aa187a6a79f Cr-Commit-Position: refs/heads/master@{#295242}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -60 lines) Patch
M chrome/browser/signin/easy_unlock_screenlock_state_handler.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc View 3 chunks +5 lines, -48 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
tbarzic
6 years, 3 months ago (2014-09-17 01:34:38 UTC) #2
Ilya Sherman
LGTM
6 years, 3 months ago (2014-09-17 04:04:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/572083004/1
6 years, 3 months ago (2014-09-17 05:09:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_swarming/builds/10261)
6 years, 3 months ago (2014-09-17 06:34:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/572083004/1
6 years, 3 months ago (2014-09-17 06:36:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3efd900189858764ba6359b46070390b658f382b
6 years, 3 months ago (2014-09-17 08:04:35 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 08:05:14 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f7d3c09bfb7efb3e3b30e0cba1b0aa187a6a79f
Cr-Commit-Position: refs/heads/master@{#295242}

Powered by Google App Engine
This is Rietveld 408576698