Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 572083003: Add a separate QUIC_CONNECTION_OVERALL_TIMED_OUT to identify overall (Closed)

Created:
6 years, 3 months ago by ramant (doing other things)
Modified:
6 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Fix_crash_on_ConnectionClose_75541290
Project:
chromium
Visibility:
Public.

Description

Add a separate QUIC_CONNECTION_OVERALL_TIMED_OUT to identify overall timeouts from idle timeouts and increase the initial overall timeout from 5s to 10s. Merge internal change: 75544619 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -19 lines) Patch
M net/quic/quic_config.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_config_test.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M net/quic/quic_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_connection_test.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M net/quic/quic_crypto_client_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_protocol.h View 3 chunks +8 lines, -5 lines 0 comments Download
M net/quic/quic_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/test_tools/mock_crypto_client_stream.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 3 months ago (2014-09-15 23:04:06 UTC) #1
Ryan Hamilton
6 years, 3 months ago (2014-09-16 03:15:34 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698