Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 572043: Check for the existance of a profile manager. Might not exist during early shutdown. (Closed)

Created:
10 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
9 years, 7 months ago
Reviewers:
michaeln, huanr
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

Check for the existance of a profile manager. Might not exist during early shutdown. BUG=34652 TEST=Execute chrome. Run chrome --uninstall. Should not crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38269

Patch Set 1 #

Total comments: 1

Patch Set 2 : added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/browser_process_impl.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jochen (gone - plz use gerrit)
please review.
10 years, 10 months ago (2010-02-05 22:38:22 UTC) #1
michaeln
LGTM
10 years, 10 months ago (2010-02-05 22:45:10 UTC) #2
huanr
http://codereview.chromium.org/572043/diff/1/2 File chrome/browser/browser_process_impl.cc (right): http://codereview.chromium.org/572043/diff/1/2#newcode271 chrome/browser/browser_process_impl.cc:271: if (!profile_manager_.get()) I see other places in this file ...
10 years, 10 months ago (2010-02-05 22:48:47 UTC) #3
jochen (gone - plz use gerrit)
Yes, that bool is used only if you want to create a profile manager, i.e. ...
10 years, 10 months ago (2010-02-05 22:54:37 UTC) #4
huanr
LGTM. Do you need to patch 249 branch? On 2010/02/05 22:54:37, jochen wrote: > Yes, ...
10 years, 10 months ago (2010-02-05 23:02:19 UTC) #5
jochen (gone - plz use gerrit)
10 years, 10 months ago (2010-02-05 23:10:19 UTC) #6
On 2010/02/05 23:02:19, huanr wrote:
> LGTM. 
> 
> Do you need to patch 249 branch?

done

Powered by Google App Engine
This is Rietveld 408576698