Check for the existance of a profile manager. Might not exist during early shutdown.

Check for the existance of a profile manager. Might not exist during early shutdown.

BUG=34652
TEST=Execute chrome. Run chrome --uninstall. Should not crash.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38269

[jochen (gone - plz use gerrit), 2010-02-05 22:38:22]

please review.

[michaeln, 2010-02-05 22:45:10]

LGTM

[huanr, 2010-02-05 22:48:47]

http://codereview.chromium.org/572043/diff/1/2
File chrome/browser/browser_process_impl.cc (right):

http://codereview.chromium.org/572043/diff/1/2#newcode271
chrome/browser/browser_process_impl.cc:271: if (!profile_manager_.get())
I see other places in this file checking created_profile_manager_ &&
profile_manager_.get(). I don't know what is the difference of those two
condition. Can you look into it and do the most appropriate thing here?

[jochen (gone - plz use gerrit), 2010-02-05 22:54:37]

Yes, that bool is used only if you want to create a profile manager, i.e. to
avoid creating it several times.

Access should be protected by checking the pointer. Even if the boolean is true,
the profile manager might not exist (new can return NULL).

On 2010/02/05 22:48:47, huanr wrote:
> http://codereview.chromium.org/572043/diff/1/2
> File chrome/browser/browser_process_impl.cc (right):
> 
> http://codereview.chromium.org/572043/diff/1/2#newcode271
> chrome/browser/browser_process_impl.cc:271: if (!profile_manager_.get())
> I see other places in this file checking created_profile_manager_ &&
> profile_manager_.get(). I don't know what is the difference of those two
> condition. Can you look into it and do the most appropriate thing here?

[huanr, 2010-02-05 23:02:19]

LGTM. 

Do you need to patch 249 branch?

On 2010/02/05 22:54:37, jochen wrote:
> Yes, that bool is used only if you want to create a profile manager, i.e. to
> avoid creating it several times.
> 
> Access should be protected by checking the pointer. Even if the boolean is
true,
> the profile manager might not exist (new can return NULL).
> 
> On 2010/02/05 22:48:47, huanr wrote:
> > http://codereview.chromium.org/572043/diff/1/2
> > File chrome/browser/browser_process_impl.cc (right):
> > 
> > http://codereview.chromium.org/572043/diff/1/2#newcode271
> > chrome/browser/browser_process_impl.cc:271: if (!profile_manager_.get())
> > I see other places in this file checking created_profile_manager_ &&
> > profile_manager_.get(). I don't know what is the difference of those two
> > condition. Can you look into it and do the most appropriate thing here?

[jochen (gone - plz use gerrit), 2010-02-05 23:10:19]

On 2010/02/05 23:02:19, huanr wrote:
> LGTM. 
> 
> Do you need to patch 249 branch?

done