Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 572023003: Remove TYPE_MALWARE_AND_PHISHING from Safe Browsing blocking page (Closed)

Created:
6 years, 3 months ago by felt
Modified:
6 years, 3 months ago
Reviewers:
mattm
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove TYPE_MALWARE_AND_PHISHING from Safe Browsing blocking page Delete support for TYPE_MALWARE_AND_PHISHING, since the warning now always shows the malware warning if it's both. BUG= R=mattm@chromium.org Committed: https://crrev.com/8cf7cebb582ec1a6b3639a3b89f08ff9772ca301 Cr-Commit-Position: refs/heads/master@{#295067}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -29 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_blocking_page.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 11 chunks +4 lines, -28 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
felt
PTAL
6 years, 3 months ago (2014-09-16 04:49:07 UTC) #1
mattm
lgtm
6 years, 3 months ago (2014-09-16 07:36:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/572023003/1
6 years, 3 months ago (2014-09-16 14:26:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 79a917e31595c1a57031a439e59cf0b06aa5dbb3
6 years, 3 months ago (2014-09-16 15:06:35 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 15:10:41 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8cf7cebb582ec1a6b3639a3b89f08ff9772ca301
Cr-Commit-Position: refs/heads/master@{#295067}

Powered by Google App Engine
This is Rietveld 408576698