chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/SyncTest.java - Issue 572013002: Removing ContentViewCore dependencies from direct WebContents functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/SyncTest.java

Issue 572013002: Removing ContentViewCore dependencies from direct WebContents functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased the patch and addressed review comments. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java ('k') | components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/SyncTest.java

diff --git a/chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/SyncTest.java b/chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/SyncTest.java

index 6a62722091baaac147d73c273535212903f129a5..d3cda45c2815e21a455500ffe129f864b7a355ca 100644

--- a/chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/SyncTest.java

+++ b/chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/SyncTest.java

@@ -148,7 +148,7 @@ public class SyncTest extends ChromeShellTestBase {

String innerHtml = "";

try {

innerHtml = JavaScriptUtils.executeJavaScriptAndWaitForResult(

- contentViewCore, "document.documentElement.innerHTML");

+ contentViewCore.getWebContents(), "document.documentElement.innerHTML");

} catch (InterruptedException e) {

Log.w(TAG, "Interrupted while polling about:sync page for sync status.", e);

} catch (TimeoutException e) {