Chromium Code Reviews
Help | Chromium Project | Sign in
(58)

Issue 5720003: Fix bug that disabled optimization when profiling. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 5 months ago by Karl Klose
Modified:
4 years ago
CC:
v8-dev
Visibility:
Public.

Description

Fix bug that disabled optimization when profiling. Committed: http://code.google.com/p/v8/source/detail?r=5972

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 4

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -20 lines) Patch
M src/runtime-profiler.cc View 1 2 3 3 chunks +23 lines, -20 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 8 (0 generated)
Karl Klose
4 years, 5 months ago (2010-12-10 13:51:50 UTC) #1
Florian Schneider
LGTM. http://codereview.chromium.org/5720003/diff/1/src/runtime-profiler.cc File src/runtime-profiler.cc (right): http://codereview.chromium.org/5720003/diff/1/src/runtime-profiler.cc#newcode429 src/runtime-profiler.cc:429: if (top_is_in_js_state) { Do you need to check ...
4 years, 5 months ago (2010-12-10 14:02:55 UTC) #2
Vitaly Repeshko
It seems wrong that state window tracking is done in SuspendIfNecessary. Why not move this ...
4 years, 5 months ago (2010-12-10 14:05:35 UTC) #3
Karl Klose
http://codereview.chromium.org/5720003/diff/1/src/runtime-profiler.cc File src/runtime-profiler.cc (right): http://codereview.chromium.org/5720003/diff/1/src/runtime-profiler.cc#newcode429 src/runtime-profiler.cc:429: if (top_is_in_js_state) { On 2010/12/10 14:02:55, fschneider1 wrote: > ...
4 years, 5 months ago (2010-12-10 14:08:48 UTC) #4
Karl Klose
> It seems wrong that state window tracking is done in SuspendIfNecessary. Why not > ...
4 years, 5 months ago (2010-12-10 14:12:56 UTC) #5
Karl Klose
On 2010/12/10 14:12:56, Karl Klose wrote: > > It seems wrong that state window tracking ...
4 years, 5 months ago (2010-12-10 14:19:30 UTC) #6
Vitaly Repeshko
LGTM Thanks, Vitaly http://codereview.chromium.org/5720003/diff/12001/src/runtime-profiler.cc File src/runtime-profiler.cc (right): http://codereview.chromium.org/5720003/diff/12001/src/runtime-profiler.cc#newcode353 src/runtime-profiler.cc:353: static void AddStateSample(SamplerState current_state) { Rename ...
4 years, 5 months ago (2010-12-10 14:40:40 UTC) #7
Karl Klose
4 years, 5 months ago (2010-12-10 14:45:06 UTC) #8
http://codereview.chromium.org/5720003/diff/12001/src/runtime-profiler.cc
File src/runtime-profiler.cc (right):

http://codereview.chromium.org/5720003/diff/12001/src/runtime-profiler.cc#new...
src/runtime-profiler.cc:353: static void AddStateSample(SamplerState
current_state) {
On 2010/12/10 14:40:40, Vitaly wrote:
> Rename to "UpdateStateRatio"?

Done.

http://codereview.chromium.org/5720003/diff/12001/src/runtime-profiler.cc#new...
src/runtime-profiler.cc:374: AddStateSample(IN_JS_STATE);
On 2010/12/10 14:40:40, Vitaly wrote:
> Nice place to use ?: operator. Up to you though.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be