net/quic/quic_flags.cc - Issue 571993002: Do not allow a QUIC connection to timeout if no packets have been sent

Side by Side Diff: net/quic/quic_flags.cc

Issue 571993002: Do not allow a QUIC connection to timeout if no packets have been sent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Minor_change_to_retransmission_75290729

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « net/quic/quic_flags.h ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "net/quic/quic_flags.h"	5 #include "net/quic/quic_flags.h"

6	6

7 // TODO(rtenneti): Remove this.	7 // TODO(rtenneti): Remove this.

8 // Do not flip this flag until the flakiness of the	8 // Do not flip this flag until the flakiness of the

9 // net/tools/quic/end_to_end_test is fixed.	9 // net/tools/quic/end_to_end_test is fixed.

10 // If true, then QUIC connections will track the retransmission history of a	10 // If true, then QUIC connections will track the retransmission history of a

(...skipping 16 matching lines...) Expand all Loading...
27 // If true, QUIC connections will support FEC protection of data while sending	27 // If true, QUIC connections will support FEC protection of data while sending

28 // packets, to reduce latency of data delivery to the application. The client	28 // packets, to reduce latency of data delivery to the application. The client

29 // must also request FEC protection for the server to use FEC.	29 // must also request FEC protection for the server to use FEC.

30 bool FLAGS_enable_quic_fec = false;	30 bool FLAGS_enable_quic_fec = false;

31	31

32 // If true, a QUIC connection with too many unfinished streams will be closed.	32 // If true, a QUIC connection with too many unfinished streams will be closed.

33 bool FLAGS_close_quic_connection_unfinished_streams = false;	33 bool FLAGS_close_quic_connection_unfinished_streams = false;

34	34

35 // When true, defaults to BBR congestion control instead of Cubic.	35 // When true, defaults to BBR congestion control instead of Cubic.

36 bool FLAGS_quic_use_bbr_congestion_control = false;	36 bool FLAGS_quic_use_bbr_congestion_control = false;

	37

	38 // If true, only times out QUIC connections when there has been network

	39 // activity; packets sent or received.

	40 bool FLAGS_quic_timeouts_require_activity = false;
	ramant (doing other things) 2014/09/15 18:05:34 Hi Ryan, Should we change the default value of t Hi Ryan, Should we change the default value of this flag to true after this change is landed? If so, will submit another CL to enable it to true. WDYT? thanks. Ryan Hamilton 2014/09/15 21:39:59 It looks like there is a bug (or two) in this CL. Show quoted text On 2014/09/15 18:05:34, ramant wrote: > Hi Ryan, > Should we change the default value of this flag to true after this change is > landed? If so, will submit another CL to enable it to true. WDYT? thanks. It looks like there is a bug (or two) in this CL. So I recommend landing with the flag off (or not landing the CL at all, but leaving the flag off is probably better) ramant (doing other things) 2014/09/15 21:41:38 +1. Will leave the flag as false. Acknowledged. Show quoted text On 2014/09/15 21:39:59, Ryan Hamilton wrote: > On 2014/09/15 18:05:34, ramant wrote: > > Hi Ryan, > > Should we change the default value of this flag to true after this change is > > landed? If so, will submit another CL to enable it to true. WDYT? thanks. > > It looks like there is a bug (or two) in this CL. So I recommend landing with > the flag off (or not landing the CL at all, but leaving the flag off is probably > better) +1. Will leave the flag as false. Acknowledged.
OLD	NEW