Issue 571993002: Do not allow a QUIC connection to timeout if no packets have been sent

Issue 571993002: Do not allow a QUIC connection to timeout if no packets have been sent (Closed)

Created:
6 years, 3 months ago by ramant (doing other things)

Modified:
6 years, 3 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@Minor_change_to_retransmission_75290729

Project:
chromium

Visibility:
Public.

More Reviews

Description

Do not allow a QUIC connection to timeout if no packets have been sent or received. Protected by FLAGS_quic_timeouts_require_activity. This seems to happen on windows from time to time and causes problems there. Merge internal change: 75304108 R=rch@chromium.org

Patch Set 1 #

Total comments: 3

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -3 lines)			Patch
M	net/quic/quic_connection.cc	View	2 chunks	+14 lines, -2 lines	0 comments	Download
M	net/quic/quic_connection_test.cc	View	1 chunk	+12 lines, -1 line	0 comments	Download
M	net/quic/quic_flags.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/quic_flags.cc	View	1 chunk	+4 lines, -0 lines	3 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

https://codereview.chromium.org/571993002/diff/1/net/quic/quic_flags.cc File net/quic/quic_flags.cc (right): https://codereview.chromium.org/571993002/diff/1/net/quic/quic_flags.cc#newcode40 net/quic/quic_flags.cc:40: bool FLAGS_quic_timeouts_require_activity = false; Hi Ryan, Should we change ...

6 years, 3 months ago (2014-09-15 18:05:34 UTC) #2

Ryan Hamilton

lgtm https://codereview.chromium.org/571993002/diff/1/net/quic/quic_flags.cc File net/quic/quic_flags.cc (right): https://codereview.chromium.org/571993002/diff/1/net/quic/quic_flags.cc#newcode40 net/quic/quic_flags.cc:40: bool FLAGS_quic_timeouts_require_activity = false; On 2014/09/15 18:05:34, ramant ...

6 years, 3 months ago (2014-09-15 21:39:59 UTC) #3

ramant (doing other things)

6 years, 3 months ago (2014-09-15 21:41:39 UTC) #4

https://codereview.chromium.org/571993002/diff/1/net/quic/quic_flags.cc
File net/quic/quic_flags.cc (right):

https://codereview.chromium.org/571993002/diff/1/net/quic/quic_flags.cc#newco...
net/quic/quic_flags.cc:40: bool FLAGS_quic_timeouts_require_activity = false;
On 2014/09/15 21:39:59, Ryan Hamilton wrote:
> On 2014/09/15 18:05:34, ramant wrote:
> > Hi Ryan,
> >   Should we change the default value of this flag to true after this change
is
> > landed? If so, will submit another CL to enable it to true. WDYT? thanks.
> 
> It looks like there is a bug (or two) in this CL. So I recommend landing with
> the flag off (or not landing the CL at all, but leaving the flag off is
probably
> better)

+1. Will leave the flag as false.

Acknowledged.

Expand Messages | Collapse Messages