Fix makefile to use chrome clang to compile, so we link to LLVM.

Fix makefile to use chrome clang to compile, so we link to LLVM.

LLVM objects/libraries are now built using clang from chrome. This
CL changes the compiler to chrome clang, and adds an appropriate
dynamic library path to the linked executable so that llvm2ice
can be run in any directory.

BUG=None
R=jvoung@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=8fcefc387b4c178fd543016e1a90f8b4336aadcf

[Karl, 2014-09-15 17:14:25]

kschimpf@google.com changed reviewers:
+ jvoung@chromium.org, stichnot@chromium.org

[jvoung (off chromium), 2014-09-15 17:51:40]

https://codereview.chromium.org/571973004/diff/20001/Makefile.standalone
File Makefile.standalone (right):

https://codereview.chromium.org/571973004/diff/20001/Makefile.standalone#newc...
Makefile.standalone:10: # LD_LIBRARY_PATH := $(LIBCXX_INSTALL_PATH)/lib
Is this needed if there's the -rpath specified?

https://codereview.chromium.org/571973004/diff/20001/Makefile.standalone#newc...
Makefile.standalone:28: LIBCXX_INSTALL_PATH ?=
../../out/libcxx_i686_linux_install/host_x86_32
Should we be using the toolchain/linux_x86/pnacl_newlib/host_x86_32 path
instead?

Do the $(shell readlink -e ...) to be consistent w/ LLVM_BIN_PATH?

[Karl, 2014-09-15 18:06:22]

https://codereview.chromium.org/571973004/diff/20001/Makefile.standalone
File Makefile.standalone (right):

https://codereview.chromium.org/571973004/diff/20001/Makefile.standalone#newc...
Makefile.standalone:10: # LD_LIBRARY_PATH := $(LIBCXX_INSTALL_PATH)/lib
On 2014/09/15 17:51:40, jvoung wrote:
> Is this needed if there's the -rpath specified?

Your right. This was a temporary workaround before I know about RPATH. Removing.

https://codereview.chromium.org/571973004/diff/20001/Makefile.standalone#newc...
Makefile.standalone:28: LIBCXX_INSTALL_PATH ?=
../../out/libcxx_i686_linux_install/host_x86_32
On 2014/09/15 17:51:40, jvoung wrote:
> Should we be using the toolchain/linux_x86/pnacl_newlib/host_x86_32 path
> instead?
> 
> Do the $(shell readlink -e ...) to be consistent w/ LLVM_BIN_PATH?

Done.

[jvoung (off chromium), 2014-09-15 18:22:32]

https://codereview.chromium.org/571973004/diff/20001/Makefile.standalone
File Makefile.standalone (right):

https://codereview.chromium.org/571973004/diff/20001/Makefile.standalone#newc...
Makefile.standalone:10: # LD_LIBRARY_PATH := $(LIBCXX_INSTALL_PATH)/lib
On 2014/09/15 18:06:22, Karl wrote:
> On 2014/09/15 17:51:40, jvoung wrote:
> > Is this needed if there's the -rpath specified?
> 
> Your right. This was a temporary workaround before I know about RPATH.
Removing.

I think you still have to upload the new patch w/ it removed?

https://codereview.chromium.org/571973004/diff/40001/Makefile.standalone
File Makefile.standalone (right):

https://codereview.chromium.org/571973004/diff/40001/Makefile.standalone#newc...
Makefile.standalone:46: $(info Using HOST_ARCH     = $(HOST_ARCH))
Maybe this info should also show the LIBCXX_INSTALL_PATH and CLANG_PATH.

[Karl, 2014-09-15 19:08:06]

https://codereview.chromium.org/571973004/diff/20001/Makefile.standalone
File Makefile.standalone (right):

https://codereview.chromium.org/571973004/diff/20001/Makefile.standalone#newc...
Makefile.standalone:10: # LD_LIBRARY_PATH := $(LIBCXX_INSTALL_PATH)/lib
On 2014/09/15 18:22:31, jvoung wrote:
> On 2014/09/15 18:06:22, Karl wrote:
> > On 2014/09/15 17:51:40, jvoung wrote:
> > > Is this needed if there's the -rpath specified?
> > 
> > Your right. This was a temporary workaround before I know about RPATH.
> Removing.
> 
> I think you still have to upload the new patch w/ it removed?

Hmm. Don't know how I missed it. Removing.

https://codereview.chromium.org/571973004/diff/40001/Makefile.standalone
File Makefile.standalone (right):

https://codereview.chromium.org/571973004/diff/40001/Makefile.standalone#newc...
Makefile.standalone:32: CLANG_PATH ?=
../../../../third_party/llvm-build/Release+Asserts/bin
I also changed this to use $(shell readlink -e ...).

https://codereview.chromium.org/571973004/diff/40001/Makefile.standalone#newc...
Makefile.standalone:46: $(info Using HOST_ARCH     = $(HOST_ARCH))
On 2014/09/15 18:22:32, jvoung wrote:
> Maybe this info should also show the LIBCXX_INSTALL_PATH and CLANG_PATH.

Done.

[jvoung (off chromium), 2014-09-15 19:24:42]

LGTM thanks

[Karl, 2014-09-15 19:56:58]

Committed patchset #4 (id:60001) manually as 8fcefc3 (tree was closed).