Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 571973003: add dumpHex() option to SkPath (Closed)

Created:
6 years, 3 months ago by caryclark
Modified:
6 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

add dumpHex() option to SkPath This provides exact precision to help debugging when the float representation of a SkScalar may introduce error. Committed: https://skia.googlesource.com/skia/+/e956259c5a4f71768afb34ec032eaed49dcbe9f2

Patch Set 1 #

Patch Set 2 : remove dummy function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -29 lines) Patch
M include/core/SkPath.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkClipStack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPath.cpp View 1 5 chunks +19 lines, -11 lines 0 comments Download
M tests/PathTest.cpp View 2 chunks +26 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
caryclark
6 years, 3 months ago (2014-09-15 15:19:51 UTC) #2
reed1
lgtm
6 years, 3 months ago (2014-09-15 16:15:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571973003/20001
6 years, 3 months ago (2014-09-15 16:18:27 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 16:26:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as e956259c5a4f71768afb34ec032eaed49dcbe9f2

Powered by Google App Engine
This is Rietveld 408576698