Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 571953002: android_webview: Build against NDK prebuilts, not system libraries. (Closed)

Created:
6 years, 3 months ago by Torne
Modified:
6 years, 2 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

android_webview: Build against NDK prebuilts, not system libraries. To allow the chromium WebView to build unbundled, we need to stop linking to system libraries and instead link to the prebuilt libraries in the NDK. This change rolls gyp to include the required makefile generation changes, and adjusts the chromium side to match: 1) Stop setting use_system_stlport and instead use the NDK stlport by specifying LOCAL_NDK_STL_VARIANT := stlport_static 2) Remove support for the use_system_stlport flag entirely as WebView was the only user. 3) Don't try to link standard libraries like -lc -lm as the NDK does this automatically. 4) Don't include the OpenAL headers from frameworks/wilhelm; these are already part of the NDK with no special include path needed. BUG=409851 Committed: https://crrev.com/3bc122f4da5cecfc6ffac44bce3fddf432afa174 Cr-Commit-Position: refs/heads/master@{#300212}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Add gyp roll to CL #

Patch Set 4 : Fix library link order on arm64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -72 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M android_webview/libwebviewchromium.gypi View 1 1 chunk +0 lines, -10 lines 0 comments Download
M build/common.gypi View 1 2 3 6 chunks +26 lines, -33 lines 0 comments Download
M build/config/android/config.gni View 1 2 chunks +1 line, -6 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 1 chunk +10 lines, -22 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Torne
+primiano, benm for general review +brettw for .gn changes This change is not ready to ...
6 years, 3 months ago (2014-09-15 14:35:36 UTC) #2
Primiano Tucci (use gerrit)
LGTM. Note that for some mysterious reason NaCL ended up copying some gyp/gn files. As ...
6 years, 3 months ago (2014-09-15 15:22:50 UTC) #3
Torne
On 2014/09/15 15:22:50, Primiano Tucci wrote: > LGTM. > Note that for some mysterious reason ...
6 years, 3 months ago (2014-09-15 15:27:28 UTC) #4
brettw
.gn lgtm
6 years, 3 months ago (2014-09-16 22:44:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/571953002/40001
6 years, 2 months ago (2014-10-17 18:01:02 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/13856)
6 years, 2 months ago (2014-10-17 18:33:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/571953002/60001
6 years, 2 months ago (2014-10-18 10:15:16 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 2 months ago (2014-10-18 11:10:27 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-18 11:11:15 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3bc122f4da5cecfc6ffac44bce3fddf432afa174
Cr-Commit-Position: refs/heads/master@{#300212}

Powered by Google App Engine
This is Rietveld 408576698