Issue 571943003: Add a PORT parameter to make serve command in the NaCl SDK Makefile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 571943003: Add a PORT parameter to make serve command in the NaCl SDK Makefile. (Closed)

Created:
6 years, 3 months ago by jpmedley

Modified:
6 years, 3 months ago

Reviewers:
binji

CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Add a PORT parameter to make serve command in the NaCl SDK Makefile. BUG= Committed: https://crrev.com/aaed1e2112c4480f8318e8058168a59bde8c875e Cr-Commit-Position: refs/heads/master@{#294868}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	native_client_sdk/src/doc/Makefile	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

jpmedley

Because I run preview.py on different ports and I'm tired of typing the path to ...

6 years, 3 months ago (2014-09-15 14:13:59 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571943003/1

6 years, 3 months ago (2014-09-15 18:02:21 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as a0419fc70cc340c4b06a8376f5b445c2fd58e0ed

6 years, 3 months ago (2014-09-15 19:34:15 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-15 19:37:37 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/aaed1e2112c4480f8318e8058168a59bde8c875e
Cr-Commit-Position: refs/heads/master@{#294868}