Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 571903002: Reland "Remove V8_HOST_CAN_READ_UNALIGNED and its uses." (Closed)

Created:
6 years, 3 months ago by Yang
Modified:
6 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Reland "Remove V8_HOST_CAN_READ_UNALIGNED and its uses." BUG=chromium:412967 LOG=N R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23938

Patch Set 1 #

Patch Set 2 : fix and test #

Total comments: 1

Patch Set 3 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -115 lines) Patch
M src/base/build_config.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/deoptimizer.h View 1 chunk +4 lines, -6 lines 0 comments Download
M src/objects.h View 1 chunk +19 lines, -8 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -30 lines 0 comments Download
M src/regexp-macro-assembler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/regexp-macro-assembler.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/regexp-macro-assembler-irregexp.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 2 chunks +32 lines, -29 lines 0 comments Download
M src/snapshot-source-sink.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/utils.h View 1 2 2 chunks +6 lines, -19 lines 0 comments Download
A + test/mjsunit/regress/string-compare-memcmp.js View 1 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Yang
Please take a look. Second patch set includes the fix and test case.
6 years, 3 months ago (2014-09-15 10:38:50 UTC) #2
Jakob Kummerow
LGTM with comment. https://codereview.chromium.org/571903002/diff/20001/src/utils.h File src/utils.h (right): https://codereview.chromium.org/571903002/diff/20001/src/utils.h#newcode686 src/utils.h:686: return memcmp(lhs, rhs, sizeof(*lhs) * chars); ...
6 years, 3 months ago (2014-09-15 10:46:48 UTC) #3
Yang
6 years, 3 months ago (2014-09-15 10:55:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 23938 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698