Added an error message when local state corruption is detected.

Added an error message when local state corruption is detected.

BUG=331367
TEST=manual testing on Linux ChromeOS build

Committed: https://crrev.com/b4d77829ff8a0069f27d6ac585ffdf79a2515cbd
Cr-Commit-Position: refs/heads/master@{#295043}

[ygorshenin1, 2014-09-15 10:14:27]

Patchset #2 (id:20001) has been deleted

[ygorshenin1, 2014-09-15 10:16:08]

ygorshenin@chromium.org changed reviewers:
+ bauerb@chromium.org

[Bernhard Bauer, 2014-09-15 11:41:33]

https://codereview.chromium.org/571893002/diff/40001/chrome/browser/prefs/chr...
File chrome/browser/prefs/chrome_pref_service_factory.cc (right):

https://codereview.chromium.org/571893002/diff/40001/chrome/browser/prefs/chr...
chrome/browser/prefs/chrome_pref_service_factory.cc:343: // will be displayed.
Shouldn't this take care of broken Local State?

[ygorshenin1, 2014-09-15 12:54:59]

https://codereview.chromium.org/571893002/diff/40001/chrome/browser/prefs/chr...
File chrome/browser/prefs/chrome_pref_service_factory.cc (right):

https://codereview.chromium.org/571893002/diff/40001/chrome/browser/prefs/chr...
chrome/browser/prefs/chrome_pref_service_factory.cc:343: // will be displayed.
On 2014/09/15 11:41:33, Bernhard Bauer wrote:
> Shouldn't this take care of broken Local State?

Recovery logic (on OOBE/login screen) is here:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/chr....

[Bernhard Bauer, 2014-09-15 13:32:09]

https://codereview.chromium.org/571893002/diff/40001/chrome/browser/prefs/chr...
File chrome/browser/prefs/chrome_pref_service_factory.cc (right):

https://codereview.chromium.org/571893002/diff/40001/chrome/browser/prefs/chr...
chrome/browser/prefs/chrome_pref_service_factory.cc:343: // will be displayed.
On 2014/09/15 12:54:59, ygorshenin1 wrote:
> On 2014/09/15 11:41:33, Bernhard Bauer wrote:
> > Shouldn't this take care of broken Local State?
> 
> Recovery logic (on OOBE/login screen) is here:
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/chr....

So, there is code that shows an error if Local State is broken? What do we need
the log statement for then? I'm confused...

[ygorshenin1, 2014-09-15 14:31:21]

I agree with you that error message displayed at device startup time is a pretty
clear indication that local state was corrupted and it's strange that it wasn't
displayed. But could you please take a look at
https://code.google.com/p/chromium/issues/detail?id=331367#c9? Situations
similar to what's described in an issue are rare, but happens sometime. Thus,
I'm not insisting, but it would be better if we'll have an individual error
message for the case when local state is corrupted - at a low level, not in
WizardController code (which exists only on OOBE/login). And if the issue will
happen again we will have slightly more information about possible causes.

[Bernhard Bauer, 2014-09-15 14:35:49]

On 2014/09/15 14:31:21, ygorshenin1 wrote:
> I agree with you that error message displayed at device startup time is a
pretty
> clear indication that local state was corrupted and it's strange that it
wasn't
> displayed. But could you please take a look at
> https://code.google.com/p/chromium/issues/detail?id=331367#c9? Situations
> similar to what's described in an issue are rare, but happens sometime. Thus,
> I'm not insisting, but it would be better if we'll have an individual error
> message for the case when local state is corrupted - at a low level, not in
> WizardController code (which exists only on OOBE/login). And if the issue will
> happen again we will have slightly more information about possible causes.

OK, I see... Can we move that code into the Chrome OS #ifdef next to the comment
then, and maybe explain that this is additional info?

[ygorshenin1, 2014-09-15 14:43:53]

Done.

[Bernhard Bauer, 2014-09-15 15:16:24]

LGTM!

[ygorshenin1, 2014-09-16 10:03:17]

The CQ bit was checked by ygorshenin@chromium.org

[ygorshenin1, 2014-09-16 10:03:28]

Many thanks!

[commit-bot: I haz the power, 2014-09-16 10:03:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/571893002/60001

[commit-bot: I haz the power, 2014-09-16 10:59:34]

Committed patchset #3 (id:60001) as 239bd14725186219c56fa6de0388e6e1b41dab65

[commit-bot: I haz the power, 2014-09-16 11:00:42]

Patchset 3 (id:??) landed as
https://crrev.com/b4d77829ff8a0069f27d6ac585ffdf79a2515cbd
Cr-Commit-Position: refs/heads/master@{#295043}