Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10099)

Unified Diff: chrome/common/BUILD.gn

Issue 571863002: GN: Get //chrome/* mostly working on android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/renderer/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/BUILD.gn
diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn
index ed83bad437cfaa272b12b2fd56f21952e0408eaf..be772a6437c6b06ed0c6a50d0639b11cd086a84c 100644
--- a/chrome/common/BUILD.gn
+++ b/chrome/common/BUILD.gn
@@ -62,8 +62,6 @@ static_library("common") {
"//components/variations",
"//content/public/common",
"//crypto",
- "//extensions:extensions_resources",
- "//extensions/strings",
"//media/cast:net",
"//net",
"//skia",
@@ -91,8 +89,6 @@ static_library("common") {
"//components/password_manager/core/common",
"//components/signin/core/common",
"//components/translate/content/common",
- "//extensions/common",
- "//extensions/common/api",
"//ipc",
"//third_party/re2",
"//third_party/widevine/cdm:version_h",
@@ -106,6 +102,10 @@ static_library("common") {
deps += [
"//device/bluetooth",
"//device/usb",
+ "//extensions/common",
+ "//extensions/common/api",
+ "//extensions/strings",
+ "//extensions:extensions_resources",
]
}
@@ -235,7 +235,7 @@ static_library("common") {
}
}
-if (is_linux) {
+if (is_linux || is_android) {
# TODO(brettw) this duplicates "//chrome/common:version" which applies to
# Windows.
import("//chrome/version.gni")
« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/renderer/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698