Issue 571853002: Revert "Create native_viewport_service, don't build it into mojo_shell unless Android"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 571853002: Revert "Create native_viewport_service, don't build it into mojo_shell unless Android" (Closed)

Created:
6 years, 3 months ago by DaveMoore

Modified:
6 years, 3 months ago

Reviewers:
jamesr

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert "Create native_viewport_service, don't build it into mojo_shell unless Android" This reverts commit 80931e51c8085d8bd44077dc1cd96bc74794e609. Linux GN build failed: http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/12251 BUG= TBR=jamesr@chromium.org Committed: https://crrev.com/b0790f7a440564c49029b4439c859d62e85b1e03 Cr-Commit-Position: refs/heads/master@{#294783}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+126 lines, -215 lines)			Patch
M	mojo/aura/aura_init.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/mojo.gyp	View	9 chunks	+26 lines, -7 lines	0 comments	Download
M	mojo/mojo_examples.gypi	View	5 chunks	+5 lines, -1 line	0 comments	Download
M	mojo/mojo_services.gypi	View	8 chunks	+5 lines, -23 lines	0 comments	Download
M	mojo/services/html_viewer/DEPS	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	mojo/services/html_viewer/html_viewer.cc	View	2 chunks	+0 lines, -17 lines	0 comments	Download
M	mojo/services/native_viewport/BUILD.gn	View	2 chunks	+9 lines, -14 lines	0 comments	Download
M	mojo/services/native_viewport/DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	mojo/services/native_viewport/main.cc	View	1 chunk	+0 lines, -102 lines	0 comments	Download
M	mojo/services/public/cpp/view_manager/lib/BUILD.gn	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	mojo/services/public/cpp/view_manager/lib/view_manager_test_suite.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	mojo/services/public/interfaces/native_viewport/native_viewport.mojom	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	mojo/services/view_manager/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	mojo/services/view_manager/ids.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	mojo/services/view_manager/view_manager_unittest.cc	View	3 chunks	+7 lines, -11 lines	0 comments	Download
M	mojo/services/window_manager/BUILD.gn	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	mojo/shell/BUILD.gn	View	4 chunks	+20 lines, -1 line	0 comments	Download
M	mojo/shell/context.cc	View	4 chunks	+25 lines, -5 lines	0 comments	Download
M	mojo/shell/desktop/mojo_main.cc	View	3 chunks	+16 lines, -11 lines	0 comments	Download
M	mojo/shell/in_process_dynamic_service_runner.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

6 years, 3 months ago (2014-09-15 04:08:50 UTC) #1

Patchset 1 (id:??) landed as
https://crrev.com/b0790f7a440564c49029b4439c859d62e85b1e03
Cr-Commit-Position: refs/heads/master@{#294783}

Expand Messages | Collapse Messages