Source/web/ServiceWorkerGlobalScopeClientImpl.h - Issue 571843003: [ServivceWorker] Treat rejecting respondWith as a Network Error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ServiceWorkerGlobalScopeClientImpl.h

Issue 571843003: [ServivceWorker] Treat rejecting respondWith as a Network Error (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: incorporated yhirano's comment Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/serviceworkers/RespondWithObserver.cpp ('K') | « Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h ('k') | Source/web/ServiceWorkerGlobalScopeClientImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/ServiceWorkerGlobalScopeClientImpl.h

diff --git a/Source/web/ServiceWorkerGlobalScopeClientImpl.h b/Source/web/ServiceWorkerGlobalScopeClientImpl.h

index cf637e5a6acee9f192f9cb4d4ecd944ca1365fde..26c10def8a6f8a43dd0dc3412ffb293a80dd6ff6 100644

--- a/Source/web/ServiceWorkerGlobalScopeClientImpl.h

+++ b/Source/web/ServiceWorkerGlobalScopeClientImpl.h

@@ -38,6 +38,7 @@

namespace blink {

class WebServiceWorkerContextClient;

+class WebServiceWorkerResponse;

class WebURL;

class ServiceWorkerGlobalScopeClientImpl FINAL : public NoBaseWillBeGarbageCollectedFinalized<ServiceWorkerGlobalScopeClientImpl>, public ServiceWorkerGlobalScopeClient {

@@ -52,7 +53,8 @@ public:

virtual void didHandleActivateEvent(int eventID, WebServiceWorkerEventResult) OVERRIDE;

virtual void didHandleInstallEvent(int installEventID, WebServiceWorkerEventResult) OVERRIDE;

- virtual void didHandleFetchEvent(int fetchEventID, Response*) OVERRIDE;

+ virtual void didHandleFetchEvent(int fetchEventID) OVERRIDE;

+ virtual void didHandleFetchEvent(int fetchEventID, const WebServiceWorkerResponse&) OVERRIDE;

virtual void didHandleSyncEvent(int syncEventID) OVERRIDE;

virtual void postMessageToClient(int clientID, const WebString& message, PassOwnPtr<WebMessagePortChannelArray>) OVERRIDE;