Source/modules/serviceworkers/RespondWithObserver.h - Issue 571843003: [ServivceWorker] Treat rejecting respondWith as a Network Error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/RespondWithObserver.h

Issue 571843003: [ServivceWorker] Treat rejecting respondWith as a Network Error (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: incorporated yhirano's comment Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/serviceworker/fetch-event.html ('k') | Source/modules/serviceworkers/RespondWithObserver.cpp » ('j') | Source/modules/serviceworkers/RespondWithObserver.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/RespondWithObserver.h

diff --git a/Source/modules/serviceworkers/RespondWithObserver.h b/Source/modules/serviceworkers/RespondWithObserver.h

index a7b9f29fcfa08fdf02ac26cf41d51106cc5e71c1..372a97b115519cfa62a4cf54846472986c8c9b9b 100644

--- a/Source/modules/serviceworkers/RespondWithObserver.h

+++ b/Source/modules/serviceworkers/RespondWithObserver.h

@@ -42,10 +42,6 @@ private:

RespondWithObserver(ExecutionContext*, int eventID);

- // Sends a response back to the client. The null response means to fallback

- // to native.

- void sendResponse(Response*);

int m_eventID;

enum State { Initial, Pending, Done };